Changeset 57841 for trunk/src/wp-includes/interactivity-api/class-wp-interactivity-api.php

Timestamp:

03/15/2024 12:10:49 PM (14 months ago)

Author:

swissspidy

Message:

Interactivity API: Do not print state if it’s an empty array.

This prunes stores and configurations that are empty arrays, as stores are expected to be JSON objects.
By not printing empty configurations, less redundant data is serialized into the HTML.

Props jonsurrell, luisherranz, darerodz, gziolo, swissspidy.
Fixes #60761.

File:

• trunk/src/wp-includes/interactivity-api/class-wp-interactivity-api.php (modified) (1 diff)

trunk/src/wp-includes/interactivity-api/class-wp-interactivity-api.php

@@ -141 +141 @@
      */
     public function print_client_interactivity_data() {
-        $store      = array();
-        $has_state  = ! empty( $this->state_data );
-        $has_config = ! empty( $this->config_data );
-
-        if ( $has_state || $has_config ) {
-            if ( $has_config ) {
-                $store['config'] = $this->config_data;
-            }
-            if ( $has_state ) {
-                $store['state'] = $this->state_data;
-            }
+        if ( empty( $this->state_data ) && empty( $this->config_data ) ) {
+            return;
+        }
+
+        $interactivity_data = array();
+
+        $config = array();
+        foreach ( $this->config_data as $key => $value ) {
+            if ( ! empty( $value ) ) {
+                $config[ $key ] = $value;
+            }
+        }
+        if ( ! empty( $config ) ) {
+            $interactivity_data['config'] = $config;
+        }
+
+        $state = array();
+        foreach ( $this->state_data as $key => $value ) {
+            if ( ! empty( $value ) ) {
+                $state[ $key ] = $value;
+            }
+        }
+        if ( ! empty( $state ) ) {
+            $interactivity_data['state'] = $state;
+        }
+
+        if ( ! empty( $interactivity_data ) ) {
             wp_print_inline_script_tag(
                 wp_json_encode(
-                    $store,
+                    $interactivity_data,
                     JSON_HEX_TAG | JSON_HEX_AMP
                 ),