Make WordPress Core

Changeset 57930


Ignore:
Timestamp:
04/04/2024 09:10:39 PM (6 months ago)
Author:
jorbin
Message:

Tests: Update expectations in wp_remote_head() and wp_remote_get() tests.

It appears that something has changed on the WP.com side to compress the requested images on the fly, which interfered with the previous expectations in these tests.

This commit uses a direct file URL and updates the expected image size to match the currently returned response.

Follow-up to [139/tests], [31258], [47142].

Reviewed by jorbin.
Merges [57903] to the 6.4 branch.

Props dextorlobo, swissspidy, davidbaumwald, SergeyBiryukov.
See #60865.

Location:
branches/6.4
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • branches/6.4

  • branches/6.4/tests/phpunit/tests/functions/wpRemoteFopen.php

    r51331 r57930  
    2727    public function test_wp_remote_fopen() {
    2828        // This URL gives a direct 200 response.
    29         $url      = 'https://asdftestblog1.files.wordpress.com/2007/09/2007-06-30-dsc_4700-1.jpg';
     29        $url      = 'https://asdftestblog1.wordpress.com/wp-content/uploads/2007/09/2007-06-30-dsc_4700-1.jpg';
    3030        $response = wp_remote_fopen( $url );
    3131
    3232        $this->assertIsString( $response );
    33         $this->assertSame( 40148, strlen( $response ) );
     33        $this->assertSame( 31325, strlen( $response ) );
    3434    }
    3535}
  • branches/6.4/tests/phpunit/tests/http/functions.php

    r55210 r57930  
    1212    public function test_head_request() {
    1313        // This URL gives a direct 200 response.
    14         $url      = 'https://asdftestblog1.files.wordpress.com/2007/09/2007-06-30-dsc_4700-1.jpg';
     14        $url      = 'https://asdftestblog1.wordpress.com/wp-content/uploads/2007/09/2007-06-30-dsc_4700-1.jpg';
    1515        $response = wp_remote_head( $url );
    1616
     
    2222
    2323        $this->assertSame( 'image/jpeg', $headers['Content-Type'] );
    24         $this->assertSame( '40148', $headers['Content-Length'] );
     24        $this->assertSame( '31325', $headers['Content-Length'] );
    2525        $this->assertSame( 200, wp_remote_retrieve_response_code( $response ) );
    2626    }
     
    4242     */
    4343    public function test_head_404() {
    44         $url      = 'https://asdftestblog1.files.wordpress.com/2007/09/awefasdfawef.jpg';
     44        $url      = 'https://asdftestblog1.wordpress.com/wp-content/uploads/2007/09/awefasdfawef.jpg';
    4545        $response = wp_remote_head( $url );
    4646
     
    6767        // Should return the same headers as a HEAD request.
    6868        $this->assertSame( 'image/jpeg', $headers['Content-Type'] );
    69         $this->assertSame( '40148', $headers['Content-Length'] );
     69        $this->assertSame( '31325', $headers['Content-Length'] );
    7070        $this->assertSame( 200, wp_remote_retrieve_response_code( $response ) );
    7171    }
     
    8888        // Should return the same headers as a HEAD request.
    8989        $this->assertSame( 'image/jpeg', $headers['Content-Type'] );
    90         $this->assertSame( '40148', $headers['Content-Length'] );
     90        $this->assertSame( '31325', $headers['Content-Length'] );
    9191        $this->assertSame( 200, wp_remote_retrieve_response_code( $response ) );
    9292    }
Note: See TracChangeset for help on using the changeset viewer.