Changeset 57948 for trunk/src/wp-includes/class-wp-theme-json.php

Timestamp:

04/09/2024 07:18:41 AM (8 months ago)

Author:

isabel_brison

Message:

Editor: skip outputting base layout rules if content and wide size values don’t exist.

Skip outputting layout rules that reference content and wide sizes CSS variables, if no layout sizes exist in the current theme.json.

Props andrewserong.
Fixes #60936.

File:

• trunk/src/wp-includes/class-wp-theme-json.php (modified) (2 diffs)

trunk/src/wp-includes/class-wp-theme-json.php

@@ -1389 +1389 @@
      * @since 6.1.0
      * @since 6.3.0 Reduced specificity for layout margin rules.
+     * @since 6.5.1 Only output rules referencing content and wide sizes when values exist.
      *
      * @param array $block_metadata Metadata about the block to get styles for.
@@ -1549 +1550 @@
                         ) {
                             foreach ( $base_style_rule['rules'] as $css_property => $css_value ) {
+                                // Skip rules that reference content size or wide size if they are not defined in the theme.json.
+                                if (
+                                    is_string( $css_value ) &&
+                                    ( str_contains( $css_value, '--global--content-size' ) || str_contains( $css_value, '--global--wide-size' ) ) &&
+                                    ! isset( $this->theme_json['settings']['layout']['contentSize'] ) &&
+                                    ! isset( $this->theme_json['settings']['layout']['wideSize'] )
+                                ) {
+                                    continue;
+                                }
+
                                 if ( static::is_safe_css_declaration( $css_property, $css_value ) ) {
                                     $declarations[] = array(