Changeset 57996

Timestamp:

04/15/2024 12:28:32 PM (2 weeks ago)

Author:

SergeyBiryukov

Message:

Tests: Use an image on WordPress.org CDN in external HTTP tests.

Due to some changes on the WP.com side to compress the requested images on the fly, the exact image size in the response could be different between platforms.

This commit aims to make the affected tests more reliable.

Follow-up to [139/tests], [31258], [34568], [47142], [57903], [57904], [57924].

Merges [57931] to the 5.5 branch.

Props peterwilsoncc, jorbin.
See #60865.

Location:

branches/5.5

Files:

• . (modified) (1 prop)
• tests/phpunit/tests/functions/wpRemoteFopen.php (modified) (1 diff)
• tests/phpunit/tests/http/functions.php (modified) (6 diffs)
• tests/phpunit/tests/image/functions.php (modified) (3 diffs)

branches/5.5/tests/phpunit/tests/functions/wpRemoteFopen.php

@@ -26 +26 @@
     public function test_wp_remote_fopen() {
         // This URL gives a direct 200 response.
-        $url      = 'https://asdftestblog1.files.wordpress.com/2007/09/2007-06-30-dsc_4700-1.jpg';
+        $url      = 'https://s.w.org/screenshots/3.9/dashboard.png';
         $response = wp_remote_fopen( $url );
 
-        $this->assertInternalType( 'string', $response );
-        $this->assertEquals( 40148, strlen( $response ) );
+        $this->assertIsString( $response );
+        $this->assertSame( 153204, strlen( $response ) );
     }
 }

branches/5.5/tests/phpunit/tests/http/functions.php

@@ -17 +17 @@
     function test_head_request() {
         // This URL gives a direct 200 response.
-        $url      = 'https://asdftestblog1.files.wordpress.com/2007/09/2007-06-30-dsc_4700-1.jpg';
+        $url      = 'https://s.w.org/screenshots/3.9/dashboard.png';
         $response = wp_remote_head( $url );
 
@@ -26 +26 @@
         $this->assertInternalType( 'array', $response );
 
-        $this->assertEquals( 'image/jpeg', $headers['content-type'] );
-        $this->assertEquals( '40148', $headers['content-length'] );
-        $this->assertEquals( '200', wp_remote_retrieve_response_code( $response ) );
+        $this->assertSame( 'image/png', $headers['Content-Type'] );
+        $this->assertSame( '153204', $headers['Content-Length'] );
+        $this->assertSame( 200, wp_remote_retrieve_response_code( $response ) );
     }
 
     function test_head_redirect() {
         // This URL will 301 redirect.
-        $url      = 'https://asdftestblog1.wordpress.com/files/2007/09/2007-06-30-dsc_4700-1.jpg';
+        $url      = 'https://wp.org/screenshots/3.9/dashboard.png';
         $response = wp_remote_head( $url );
 
@@ -40 +40 @@
     }
 
-    function test_head_404() {
-        $url      = 'https://asdftestblog1.files.wordpress.com/2007/09/awefasdfawef.jpg';
+    /**
+     * @covers ::wp_remote_head
+     */
+    public function test_head_404() {
+        $url      = 'https://wordpress.org/screenshots/3.9/awefasdfawef.jpg';
         $response = wp_remote_head( $url );
 
@@ -48 +51 @@
     }
 
-    function test_get_request() {
-        $url = 'https://asdftestblog1.files.wordpress.com/2007/09/2007-06-30-dsc_4700-1.jpg';
+    /**
+     * @covers ::wp_remote_get
+     * @covers ::wp_remote_retrieve_headers
+     * @covers ::wp_remote_retrieve_response_code
+     */
+    public function test_get_request() {
+        $url = 'https://s.w.org/screenshots/3.9/dashboard.png';
 
         $response = wp_remote_get( $url );
@@ -60 +68 @@
 
         // Should return the same headers as a HEAD request.
-        $this->assertEquals( 'image/jpeg', $headers['content-type'] );
-        $this->assertEquals( '40148', $headers['content-length'] );
-        $this->assertEquals( '200', wp_remote_retrieve_response_code( $response ) );
+        $this->assertSame( 'image/png', $headers['Content-Type'] );
+        $this->assertSame( '153204', $headers['Content-Length'] );
+        $this->assertSame( 200, wp_remote_retrieve_response_code( $response ) );
     }
 
     function test_get_redirect() {
-        // This will redirect to asdftestblog1.files.wordpress.com.
-        $url = 'https://asdftestblog1.wordpress.com/files/2007/09/2007-06-30-dsc_4700-1.jpg';
+        // This will redirect to wordpress.org.
+        $url = 'https://wp.org/screenshots/3.9/dashboard.png';
 
         $response = wp_remote_get( $url );
@@ -76 +84 @@
 
         // Should return the same headers as a HEAD request.
-        $this->assertEquals( 'image/jpeg', $headers['content-type'] );
-        $this->assertEquals( '40148', $headers['content-length'] );
-        $this->assertEquals( '200', wp_remote_retrieve_response_code( $response ) );
+        $this->assertSame( 'image/png', $headers['Content-Type'] );
+        $this->assertSame( '153204', $headers['Content-Length'] );
+        $this->assertSame( 200, wp_remote_retrieve_response_code( $response ) );
     }
 
     function test_get_redirect_limit_exceeded() {
-        // This will redirect to asdftestblog1.files.wordpress.com.
-        $url = 'https://asdftestblog1.wordpress.com/files/2007/09/2007-06-30-dsc_4700-1.jpg';
+        // This will redirect to wordpress.org.
+        $url = 'https://wp.org/screenshots/3.9/dashboard.png';
 
         // Pretend we've already redirected 5 times.

branches/5.5/tests/phpunit/tests/image/functions.php

@@ -336 +336 @@
 
         $file = wp_crop_image(
-            'https://asdftestblog1.files.wordpress.com/2008/04/canola.jpg',
+            'https://s.w.org/screenshots/3.9/dashboard.png',
             0,
             0,
@@ -344 +344 @@
             100,
             false,
-            DIR_TESTDATA . '/images/' . __FUNCTION__ . '.jpg'
+            DIR_TESTDATA . '/images/' . __FUNCTION__ . '.png'
         );
 
@@ -380 +380 @@
 
         $file = wp_crop_image(
-            'https://asdftestblog1.files.wordpress.com/2008/04/canoladoesnotexist.jpg',
+            'https://wordpress.org/screenshots/3.9/canoladoesnotexist.jpg',
             0,
             0,