Changeset 58044

Timestamp:

04/24/2024 10:03:06 PM (17 months ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in WP_oEmbed_Controller tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [41047].

Props costdev.
See #60706.

File:

• trunk/tests/phpunit/tests/oembed/controller.php (modified) (1 diff)

trunk/tests/phpunit/tests/oembed/controller.php

@@ -607 +607 @@
         $this->assertSame( 'YouTube', $data->provider_name );
         $this->assertSame( 'https://i.ytimg.com/vi/' . self::YOUTUBE_VIDEO_ID . '/hqdefault.jpg', $data->thumbnail_url );
-        $this->assertEquals( $data->width, $request['maxwidth'] );
-        $this->assertEquals( $data->height, $request['maxheight'] );
+        $this->assertSame( (int) $data->width, $request['maxwidth'] );
+        $this->assertSame( (int) $data->height, $request['maxheight'] );
     }