Changeset 58062 for trunk/src/wp-admin/includes/class-language-pack-upgrader.php

Timestamp:

04/30/2024 08:37:25 AM (2 years ago)

Author:

swissspidy

Message:

I18N: Actually add all the files for [58061], not just the test fixtures.

Improve support for using only PHP translation files.

This builds on top of the PHP translation file support added in WordPress 6.5, improving the behavior for projects using solely .l10n.php translation files and no .mo. and .po files.

Updates wp_get_installed_translations(), which is used when updating language packs and when uninstalling plugins/themes (to remove the translations again), to look for PHP translation files and read metadata from them. Additionally, the file lookup is now cached thanks to using WP_Textdomain_Registry.

Updates Language_Pack_Upgrader::check_package() to allow language packs that only contain PHP translation files. While WordPress.org continues to serve .mo and .po files, third-party services might want to only use the PHP file format.

See #60554.

File:

• trunk/src/wp-admin/includes/class-language-pack-upgrader.php (modified) (3 diffs)

trunk/src/wp-admin/includes/class-language-pack-upgrader.php

@@ -333 +333 @@
                 $files = $wp_filesystem->dirlist( $remote_source );
 
-                // Check to see if a .po and .mo exist in the folder.
-                $po = false;
-                $mo = false;
+                // Check to see if the expected files exist in the folder.
+                $po  = false;
+                $mo  = false;
+                $php = false;
                 foreach ( (array) $files as $file => $filedata ) {
                         if ( str_ends_with( $file, '.po' ) ) {
@@ -341 +342 @@
                         } elseif ( str_ends_with( $file, '.mo' ) ) {
                                 $mo = true;
-                        }
+                        } elseif ( str_ends_with( $file, '.l10n.php' ) ) {
+                                $php = true;
+                        }
+                }
+
+                if ( $php ) {
+                        return $source;
                 }
 
@@ -349 +356 @@
                                 $this->strings['incompatible_archive'],
                                 sprintf(
-                                        /* translators: 1: .po, 2: .mo */
-                                        __( 'The language pack is missing either the %1$s or %2$s files.' ),
+                                        /* translators: 1: .po, 2: .mo, 3: .l10n.php */
+                                        __( 'The language pack is missing either the %1$s, %2$s, or %3$s files.' ),
                                         '<code>.po</code>',
-                                        '<code>.mo</code>'
+                                        '<code>.mo</code>',
+                                        '<code>.l10n.php</code>'
                                 )
                         );