Changeset 58069 for trunk/src/wp-admin/includes/class-wp-theme-install-list-table.php

Timestamp:

05/01/2024 05:59:05 PM (2 years ago)

Author:

swissspidy

Message:

General: Remove any usage of wp_reset_vars().

The way wp_reset_vars() sets global variables based on $_POST and $_GET values makes code hard to understand and maintain. It also makes it easy to forget to sanitize input.

This change removes the few places where wp_reset_vars() is used in the admin to explicitly use $_REQUEST and sanitize any input.

Props swissspidy, audrasjb, davideferre, killua99, weijland, voldemortensen.
Fixes #38073.

File:

• trunk/src/wp-admin/includes/class-wp-theme-install-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-theme-install-list-table.php

@@ -37 +37 @@
 
                 global $tabs, $tab, $paged, $type, $theme_field_defaults;
-                wp_reset_vars( array( 'tab' ) );
+
+                $tab = ! empty( $_REQUEST['tab'] ) ? sanitize_text_field( $_REQUEST['tab'] ) : '';
 
                 $search_terms  = array();