Changeset 58108 for trunk/tests/phpunit/tests/http/base.php

Timestamp:

05/06/2024 06:39:15 PM (8 months ago)

Author:

johnbillion

Message:

Build/Test Tools: Standardise the assertions for remote HTTP request tests.

This ensures that as much information as possible is shown when an HTTP request fails during an external HTTP test.

Fixes #61148

File:

• trunk/tests/phpunit/tests/http/base.php (modified) (4 diffs)

trunk/tests/phpunit/tests/http/base.php

@@ -220 +220 @@
 
         $this->skipTestOnTimeout( $res );
+        $this->assertNotWPError( $res );
         $this->assertSame( 'PASS', wp_remote_retrieve_body( $res ) );
         $this->assertNotEmpty( $res['headers']['location'] );
@@ -357 +358 @@
 
         $this->skipTestOnTimeout( $res );
+        $this->assertNotWPError( $res );
         $this->assertSame( $method, wp_remote_retrieve_body( $res ) );
     }
@@ -407 +409 @@
 
         $this->skipTestOnTimeout( $res );
+        $this->assertNotWPError( $res );
         $this->assertSame( 'PASS', wp_remote_retrieve_body( $res ) );
     }
@@ -448 +451 @@
 
         $this->skipTestOnTimeout( $res );
+        $this->assertNotWPError( $res );
         $this->assertSame( 'PASS', wp_remote_retrieve_body( $res ) );
     }