Changeset 58150

Timestamp:

05/15/2024 01:07:35 AM (5 months ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in absint() tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Includes correcting a few erroneously duplicated test cases to match their intended purpose.

Follow-up to [57724].

See #60706.

File:

• trunk/tests/phpunit/tests/functions/absint.php (modified) (3 diffs)

trunk/tests/phpunit/tests/functions/absint.php

@@ -2 +2 @@
 
 /**
- * Tests for the absint function.
+ * Tests for the absint() function.
  *
  * @group functions
@@ -8 +8 @@
  * @covers ::absint
  */
-class Tests_Functions_absint extends WP_UnitTestCase {
+class Tests_Functions_Absint extends WP_UnitTestCase {
 
     /**
@@ -15 +15 @@
      * @dataProvider data_absint
      */
-    public function test_absint( $maybe_int, $expected_value ) {
-
-        $this->assertEquals( $expected_value, absint( $maybe_int ) );
+    public function test_absint( $test_value, $expected_value ) {
+        $this->assertSame( $expected_value, absint( $test_value ) );
     }
 
     /**
-     * @ticket 60101
+     * Data provider.
      *
-     * Returns an array of test data for the `data_absint` method.
-     *
-     * @return array[] An array of test data.
+     * @return array[] Test parameters {
+     *     @type string $test_value Test value.
+     *     @type string $expected   Expected return value.
+     * }
      */
     public function data_absint() {
         return array(
-            '1_int'                 => array(
-                'maybe_int'      => 1,
+            '1 int'                 => array(
+                'test_value'     => 1,
                 'expected_value' => 1,
             ),
-            '9.1_int'               => array(
-                'maybe_int'      => 9.1,
+            '1 string'              => array(
+                'test_value'     => '1',
+                'expected_value' => 1,
+            ),
+            '-1 int'                => array(
+                'test_value'     => -1,
+                'expected_value' => 1,
+            ),
+            '-1 string'             => array(
+                'test_value'     => '-1',
+                'expected_value' => 1,
+            ),
+            '9.1 float'             => array(
+                'test_value'     => 9.1,
                 'expected_value' => 9,
             ),
-            '9.9_int'               => array(
-                'maybe_int'      => 9.9,
+            '9.9 float'             => array(
+                'test_value'     => 9.9,
                 'expected_value' => 9,
             ),
-            '1_string'              => array(
-                'maybe_int'      => 1,
-                'expected_value' => '1',
+            'string'                => array(
+                'test_value'     => 'string',
+                'expected_value' => 0,
             ),
-            '-1_int'                => array(
-                'maybe_int'      => 1,
-                'expected_value' => 1,
-            ),
-            '-1_string'             => array(
-                'maybe_int'      => 1,
-                'expected_value' => 1,
-            ),
-            'string'                => array(
-                'maybe_int'      => 'string',
+            'string_1'              => array(
+                'test_value'     => 'string_1',
                 'expected_value' => 0,
             ),
             '999_string'            => array(
-                'maybe_int'      => '999_string',
+                'test_value'     => '999_string',
                 'expected_value' => 999,
             ),
-            'string_1'              => array(
-                'maybe_int'      => 'string_1',
-                'expected_value' => 0,
-            ),
             '99 string with spaces' => array(
-                'maybe_int'      => '99 string with spaces',
+                'test_value'     => '99 string with spaces',
                 'expected_value' => 99,
             ),
-            'array(99)'             => array(
-                'maybe_int'      => array( 99 ),
+            '99 array'              => array(
+                'test_value'     => array( 99 ),
                 'expected_value' => 1,
             ),
-            'array("99")'           => array(
-                'maybe_int'      => array( '99' ),
+            '99 string array'       => array(
+                'test_value'     => array( '99' ),
                 'expected_value' => 1,
             ),