Changeset 58161

Timestamp:

05/16/2024 03:29:57 PM (5 months ago)

Author:

jorbin

Message:

Plugins: Assign role of button to links that act as buttons.

Clicking on these links initiates an action, so they are more semantically a button rather than a link. Keeping them as an anchor in html allows any existing JS that is targeted to these items to continue to function. The addition of the role helps assistive technology to know that they should treat this as a button.

Props stevejonesdev, sabernhardt, vipulgupta003, rcreators, joedolson.
Fixes #61011.

File:

• trunk/src/wp-admin/includes/plugin-install.php (modified) (4 diffs)

trunk/src/wp-admin/includes/plugin-install.php

@@ -944 +944 @@
 
     sprintf(
-        '<a class="install-now button" data-slug="%s" href="%s" aria-label="%s" data-name="%s">%s</a>',
+        '<a class="install-now button" data-slug="%s" href="%s" aria-label="%s" data-name="%s" role="button">%s</a>',
         esc_attr( $data->slug ),
         esc_url( $status['url'] ),
@@ -959 +959 @@
                     if ( $compatible_php && $compatible_wp && $all_plugin_dependencies_installed && ! empty( $data->download_link ) ) {
                         $button = sprintf(
-                            '<a class="install-now button" data-slug="%s" href="%s" aria-label="%s" data-name="%s">%s</a>',
+                            '<a class="install-now button" data-slug="%s" href="%s" aria-label="%s" data-name="%s" role="button">%s</a>',
                             esc_attr( $data->slug ),
                             esc_url( $status['url'] ),
@@ -980 +980 @@
                     if ( $compatible_php && $compatible_wp ) {
                         $button = sprintf(
-                            '<a class="update-now button aria-button-if-js" data-plugin="%s" data-slug="%s" href="%s" aria-label="%s" data-name="%s">%s</a>',
+                            '<a class="update-now button aria-button-if-js" data-plugin="%s" data-slug="%s" href="%s" aria-label="%s" data-name="%s" role="button">%s</a>',
                             esc_attr( $status['file'] ),
                             esc_attr( $data->slug ),
@@ -1027 +1027 @@
 
                         $button = sprintf(
-                            '<a href="%1$s" data-name="%2$s" data-slug="%3$s" data-plugin="%4$s" class="button button-primary activate-now" aria-label="%5$s">%6$s</a>',
+                            '<a href="%1$s" data-name="%2$s" data-slug="%3$s" data-plugin="%4$s" class="button button-primary activate-now" aria-label="%5$s" role="button">%6$s</a>',
                             esc_url( $activate_url ),
                             esc_attr( $name ),