Changeset 58174

Timestamp:

05/20/2024 09:47:41 AM (4 months ago)

Author:

youknowriad

Message:

Posts: Ensure get_sample_permalink returns the right permalink for auto-draft posts.

The post editor uses the permalink_template property from the posts REST API to render the post slug input or not. For auto-drafts or newly created posts, this property was not set properly. This PR solves by fixing the get_sample_permalink function used to compute this property.

Props youknowriad, mcsf, antonvlasenko, azaozz, peterwilsoncc, andrewserong, hellofromTonya, spacedmonkey.
Fixes #59283.

Location:

trunk

Files:

• src/wp-admin/includes/post.php (modified) (1 diff)
• src/wp-includes/post.php (modified) (1 diff)
• tests/phpunit/tests/admin/includesPost.php (modified) (1 diff)

trunk/src/wp-admin/includes/post.php

@@ -1464 +1464 @@
 
     // Hack: get_permalink() would return plain permalink for drafts, so we will fake that our post is published.
-    if ( in_array( $post->post_status, array( 'draft', 'pending', 'future' ), true ) ) {
+    if ( in_array( $post->post_status, array( 'auto-draft', 'draft', 'pending', 'future' ), true ) ) {
         $post->post_status = 'publish';
         $post->post_name   = sanitize_title( $post->post_name ? $post->post_name : $post->post_title, $post->ID );

trunk/src/wp-includes/post.php

@@ -1220 +1220 @@
  */
 function get_post_status( $post = null ) {
-    $post = get_post( $post );
+    if ( $post instanceof WP_Post && isset( $post->filter ) && 'sample' === $post->filter ) {
+        // Skip normalization
+    } else {
+        $post = get_post( $post );
+    }
 
     if ( ! is_object( $post ) ) {

trunk/tests/phpunit/tests/admin/includesPost.php

@@ -931 +931 @@
         get_sample_permalink( $post );
         $this->assertEquals( $post_original, $post, 'get_sample_permalink() modifies the post object.' );
+    }
+
+    /**
+     * @ticket 59283
+     */
+    public function test_get_sample_permalink_should_return_pretty_permalink_for_posts_with_post_status_auto_draft() {
+        $permalink_structure = '%postname%';
+        $this->set_permalink_structure( "/$permalink_structure/" );
+
+        $future_date = gmdate( 'Y-m-d H:i:s', time() + 100 );
+        $p           = self::factory()->post->create(
+            array(
+                'post_status' => 'auto-draft',
+                'post_name'   => 'foo',
+                'post_date'   => $future_date,
+            )
+        );
+
+        $found    = get_sample_permalink( $p );
+        $expected = trailingslashit( home_url( $permalink_structure ) );
+
+        $this->assertSame( $expected, $found[0] );
     }