Changeset 58181

Timestamp:

05/21/2024 10:31:51 AM (5 weeks ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in block support tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Includes renaming a few test classes per the naming conventions.

Reference: ​Writing PHP Tests: Naming and Organization.

Follow-up to [53076], [53085], [54497], [56046], [56614], [57246], [57491].

See #60705.

Location:

trunk/tests/phpunit/tests/block-supports

Files:

• border.php (modified) (1 diff)
• layout.php (modified) (2 diffs)
• shadow.php (modified) (1 diff)
• spacing.php (modified) (1 diff)
• typography.php (modified) (6 diffs)
• wpRenderBackgroundSupport.php (modified) (1 diff)
• wpRenderDimensionsSupport.php (modified) (1 diff)

trunk/tests/phpunit/tests/block-supports/border.php

@@ -5 +5 @@
  * @covers ::wp_apply_border_support
  */
-class Test_Block_Supports_Border extends WP_UnitTestCase {
+class Tests_Block_Supports_Border extends WP_UnitTestCase {
     /**
      * @var string|null

trunk/tests/phpunit/tests/block-supports/layout.php

@@ -11 +11 @@
  * @covers ::wp_restore_image_outer_container
  */
-class Test_Block_Supports_Layout extends WP_UnitTestCase {
+class Tests_Block_Supports_Layout extends WP_UnitTestCase {
 
     /**
@@ -311 +311 @@
     public function test_restore_group_inner_container( $args, $expected_output ) {
         $actual_output = wp_restore_group_inner_container( $args['block_content'], $args['block'] );
-        $this->assertEquals( $expected_output, $actual_output );
+        $this->assertSame( $expected_output, $actual_output );
     }
 

trunk/tests/phpunit/tests/block-supports/shadow.php

@@ -5 +5 @@
  * @covers ::wp_apply_shadow_support
  */
-class Test_Block_Supports_Shadow extends WP_UnitTestCase {
+class Tests_Block_Supports_Shadow extends WP_UnitTestCase {
     /**
      * @var string|null

trunk/tests/phpunit/tests/block-supports/spacing.php

@@ -5 +5 @@
  * @covers ::wp_apply_spacing_support
  */
-class Test_Block_Supports_Spacing extends WP_UnitTestCase {
+class Tests_Block_Supports_Spacing extends WP_UnitTestCase {
     /**
      * @var string|null

trunk/tests/phpunit/tests/block-supports/typography.php

@@ -1119 +1119 @@
      */
     public function test_valid_size_wp_get_typography_value_and_unit( $raw_value, $expected ) {
-        $this->assertEquals( $expected, wp_get_typography_value_and_unit( $raw_value ) );
+        $this->assertSame( $expected, wp_get_typography_value_and_unit( $raw_value ) );
     }
 
@@ -1144 +1144 @@
                 'raw_value' => '10',
                 'expected'  => array(
-                    'value' => 10,
+                    'value' => 10.0,
                     'unit'  => 'px',
                 ),
@@ -1151 +1151 @@
                 'raw_value' => 11,
                 'expected'  => array(
-                    'value' => 11,
+                    'value' => 11.0,
                     'unit'  => 'px',
                 ),
@@ -1165 +1165 @@
                 'raw_value' => '12rem',
                 'expected'  => array(
-                    'value' => 12,
+                    'value' => 12.0,
                     'unit'  => 'rem',
                 ),
@@ -1172 +1172 @@
                 'raw_value' => '12px',
                 'expected'  => array(
-                    'value' => 12,
+                    'value' => 12.0,
                     'unit'  => 'px',
                 ),
@@ -1179 +1179 @@
                 'raw_value' => '12em',
                 'expected'  => array(
-                    'value' => 12,
+                    'value' => 12.0,
                     'unit'  => 'em',
                 ),

trunk/tests/phpunit/tests/block-supports/wpRenderBackgroundSupport.php

@@ -111 +111 @@
         $actual = wp_render_background_support( $wrapper, $block );
 
-        $this->assertEquals(
+        $this->assertSame(
             $expected_wrapper,
             $actual,

trunk/tests/phpunit/tests/block-supports/wpRenderDimensionsSupport.php

@@ -110 +110 @@
         $actual = wp_render_dimensions_support( $wrapper, $block );
 
-        $this->assertEquals(
+        $this->assertSame(
             $expected_wrapper,
             $actual,