Changeset 58201 for trunk/tests/phpunit/tests/post/types.php

Timestamp:

05/27/2024 09:04:10 AM (4 months ago)

Author:

swissspidy

Message:

Posts, Post Types: Autosave: Allow disabling autosave support per post type.

Not all post types support autosaving. By making autosave a post type feature, support can be more granularly handled without any workarounds or hardcoded allowlists. wp_font_family and wp_font_face are examples of built-in post types which do not support autosave.

For backward compatibility reasons, adding editor support implies autosave support, so one would need to explicitly use remove_post_type_support() to remove it again.

Props swissspidy, youknowriad, hellofromtonya, peterwilsoncc.
Fixes #41172.

File:

• trunk/tests/phpunit/tests/post/types.php (modified) (3 diffs)

trunk/tests/phpunit/tests/post/types.php

@@ -218 +218 @@
     /**
      * @ticket 21586
+     * @ticket 41172
      */
     public function test_post_type_with_no_support() {
         register_post_type( 'foo', array( 'supports' => array() ) );
-        $this->assertTrue( post_type_supports( 'foo', 'editor' ) );
-        $this->assertTrue( post_type_supports( 'foo', 'title' ) );
+        $this->assertTrue( post_type_supports( 'foo', 'editor' ), 'Editor support should be enabled by default.' );
+        $this->assertTrue( post_type_supports( 'foo', 'title' ), 'Title support should be enabled by default.' );
+        $this->assertTrue( post_type_supports( 'foo', 'autosave' ), 'Autosaves support should be enabled by default.' );
         _unregister_post_type( 'foo' );
 
         register_post_type( 'foo', array( 'supports' => false ) );
-        $this->assertFalse( post_type_supports( 'foo', 'editor' ) );
-        $this->assertFalse( post_type_supports( 'foo', 'title' ) );
+        $this->assertFalse( post_type_supports( 'foo', 'editor' ), 'Editor support should be disabled.' );
+        $this->assertFalse( post_type_supports( 'foo', 'title' ), 'Title support should be disabled.' );
+        $this->assertFalse( post_type_supports( 'foo', 'autosave' ), 'Autosaves support should be disabled.' );
         _unregister_post_type( 'foo' );
     }
@@ -433 +436 @@
         $this->assertSameSetsWithIndex(
             array(
-                'editor' => true,
-                'author' => true,
-                'title'  => true,
+                'editor'   => true,
+                'author'   => true,
+                'title'    => true,
+                'autosave' => true,
             ),
             $_wp_post_type_features['foo']
@@ -590 +594 @@
         $this->assertSameSets( array(), get_post_types_by_support( 'somefeature' ) );
     }
+
+    /**
+     * @ticket 41172
+     */
+    public function test_post_type_supports_autosave_based_on_editor_support() {
+        register_post_type( 'foo', array( 'supports' => array( 'editor' ) ) );
+        $this->assertTrue( post_type_supports( 'foo', 'autosave' ) );
+        _unregister_post_type( 'foo' );
+
+        register_post_type( 'foo', array( 'supports' => array( 'title' ) ) );
+        $this->assertFalse( post_type_supports( 'foo', 'autosave' ) );
+        _unregister_post_type( 'foo' );
+    }
+
+    /**
+     * @ticket 41172
+     */
+    public function test_removing_autosave_support_removes_rest_api_controller() {
+        register_post_type(
+            'foo',
+            array(
+                'show_in_rest' => true,
+                'supports'     => array( 'editor' ),
+            )
+        );
+
+        $post_type_object = get_post_type_object( 'foo' );
+        $this->assertInstanceOf( 'WP_REST_Autosaves_Controller', $post_type_object->get_autosave_rest_controller(), 'Autosave controller should be set by default.' );
+
+        remove_post_type_support( 'foo', 'autosave' );
+        $post_type_object = get_post_type_object( 'foo' );
+        $this->assertSame( null, $post_type_object->get_autosave_rest_controller(), 'Autosave controller should be removed.' );
+        _unregister_post_type( 'foo' );
+    }
+
+    /**
+     * @ticket 41172
+     */
+    public function test_removing_editor_support_does_not_remove_autosave_support() {
+        register_post_type(
+            'foo',
+            array(
+                'show_in_rest' => true,
+                'supports'     => array( 'editor' ),
+            )
+        );
+        remove_post_type_support( 'foo', 'editor' );
+
+        $this->assertFalse( post_type_supports( 'foo', 'editor' ), 'Post type should not support editor.' );
+        $this->assertTrue( post_type_supports( 'foo', 'autosave' ), 'Post type should still support autosaves.' );
+    }
 }