Changeset 58206

Timestamp:

05/27/2024 12:26:51 PM (6 months ago)

Author:

karmatosed

Message:

Twenty Seventeen: Add filter for display of featured image in header.

When a layout doesn't use custom post types it was appearing broken. This adds a filter for the display of the featured image to resolve this.

Props justnorris, JPry, davidakennedy, SergeyBiryukov, zkarj, poena, nhrrob, lamarajan.
Fixes #39281.

Location:

trunk/src/wp-content/themes/twentyseventeen

Files:

• functions.php (modified) (1 diff)
• header.php (modified) (1 diff)

trunk/src/wp-content/themes/twentyseventeen/functions.php

@@ -691 +691 @@
 
 /**
+ * If a regular post or page, and not the front page, show the featured image below the header.
+ * Using get_queried_object_id() here since the $post global may not be set before a call to the_post().
+ *
+ * @since Twenty Seventeen 3.7
+ *
+ * @return bool Whether the post thumbnail should be shown.
+ */
+function twentyseventeen_should_show_featured_image() {
+    $show_featured_image = ( is_single() || ( is_page() && ! twentyseventeen_is_frontpage() ) ) && has_post_thumbnail( get_queried_object_id() );
+    return apply_filters( 'twentyseventeen_should_show_featured_image', $show_featured_image );
+}
+
+/**
  * Implement the Custom Header feature.
  */

trunk/src/wp-content/themes/twentyseventeen/header.php

@@ -48 +48 @@
 
     <?php
-
-    /*
-     * If a regular post or page, and not the front page, show the featured image.
-     * Using get_queried_object_id() here since the $post global may not be set before a call to the_post().
-     */
-    if ( ( is_single() || ( is_page() && ! twentyseventeen_is_frontpage() ) ) && has_post_thumbnail( get_queried_object_id() ) ) :
+    if ( twentyseventeen_should_show_featured_image() ) :
         echo '<div class="single-featured-image-header">';
         echo get_the_post_thumbnail( get_queried_object_id(), 'twentyseventeen-featured-image' );