Changeset 58208

Timestamp:

05/27/2024 01:53:55 PM (2 years ago)

Author:

audrasjb

Message:

HTTP API: Improve download_url() error message.

This changeset improves the error message returned when no URL is provided, and updates the related unit tests accordingly.

Props hinnerk, audrasjb.
Fixes #60565.

Location:

trunk

Files:

• src/wp-admin/includes/file.php (modified) (1 diff)
• tests/phpunit/tests/admin/includesFile.php (modified) (1 diff)

trunk/src/wp-admin/includes/file.php

@@ -1156 +1156 @@
         // WARNING: The file is not automatically deleted, the script must delete or move the file.
         if ( ! $url ) {
-                return new WP_Error( 'http_no_url', __( 'Invalid URL Provided.' ) );
+                return new WP_Error( 'http_no_url', __( 'No URL Provided.' ) );
         }
 

trunk/tests/phpunit/tests/admin/includesFile.php

@@ -295 +295 @@
                 $this->assertWPError( $error );
                 $this->assertSame( 'http_no_url', $error->get_error_code() );
-                $this->assertSame( 'Invalid URL Provided.', $error->get_error_message() );
+                $this->assertSame( 'No URL Provided.', $error->get_error_message() );
         }