Changeset 58215

Timestamp:

05/27/2024 06:39:53 PM (2 years ago)

Author:

joedolson

Message:

Toolbar: Accessibility: Fix keyboard focus order of search form.

Change the priority of the search form & remove float so that the visual position of the form matches it's positioning in the DOM.

This sets the priority of the search form to an arbitrarily high value of 9999 to ensure it will generally be last in the DOM.

Props joedolson, sabernhardt, audrasjb.
Fixes #60685.

Location:

trunk/src/wp-includes

Files:

• class-wp-admin-bar.php (modified) (1 diff)
• css/admin-bar.css (modified) (2 diffs)

trunk/src/wp-includes/class-wp-admin-bar.php

@@ -649 +649 @@
                 // User-related, aligned right.
                 add_action( 'admin_bar_menu', 'wp_admin_bar_my_account_menu', 0 );
-                add_action( 'admin_bar_menu', 'wp_admin_bar_search_menu', 4 );
                 add_action( 'admin_bar_menu', 'wp_admin_bar_my_account_item', 7 );
                 add_action( 'admin_bar_menu', 'wp_admin_bar_recovery_mode_menu', 8 );
+                add_action( 'admin_bar_menu', 'wp_admin_bar_search_menu', 9999 );
 
                 // Site-related.

trunk/src/wp-includes/css/admin-bar.css

@@ -127 +127 @@
 #wpadminbar .ab-empty-item {
         outline: none;
-}
-
-#wpadminbar .quicklinks .ab-top-secondary > li {
-        float: right;
 }
 
@@ -1039 +1035 @@
         }
 
-        #wpadminbar #wp-admin-bar-my-account {
-                float: right;
-        }
-
         .network-admin #wpadminbar ul#wp-admin-bar-top-secondary > li#wp-admin-bar-my-account {
                 margin-right: 0;