Changeset 58221

Timestamp:

05/28/2024 05:25:06 AM (5 months ago)

Author:

peterwilsoncc

Message:

Build/Test Tools: Assert files exist/do not exist directly.

Replaces various boolean assertions wrapping file_exists() with either assertFileExists() or assertFileDoesNotExist() as appropriate for the test.

Props peterwilsoncc, mukesh27.
See #60705.

Location:

trunk/tests/phpunit/tests

Files:

• fonts/font-library/fontLibraryHooks.php (modified) (1 diff)
• privacy/wpPrivacyDeleteOldExportFiles.php (modified) (4 diffs)
• privacy/wpPrivacyGeneratePersonalDataExportFile.php (modified) (3 diffs)

trunk/tests/phpunit/tests/fonts/font-library/fontLibraryHooks.php

@@ -47 +47 @@
         wp_delete_post( $font_face_id, true );
 
-        $this->assertFalse( file_exists( $font_path ), 'The font file should have been deleted when the post was deleted.' );
-        $this->assertTrue( file_exists( $other_font_path ), 'The other font file should exist.' );
+        $this->assertFileDoesNotExist( $font_path, 'The font file should have been deleted when the post was deleted.' );
+        $this->assertFileExists( $other_font_path, 'The other font file should exist.' );
     }
 

trunk/tests/phpunit/tests/privacy/wpPrivacyDeleteOldExportFiles.php

@@ -114 +114 @@
         wp_privacy_delete_old_export_files();
 
-        $this->assertFalse( file_exists( self::$expired_export_file ) );
+        $this->assertFileDoesNotExist( self::$expired_export_file );
     }
 
@@ -125 +125 @@
         wp_privacy_delete_old_export_files();
 
-        $this->assertTrue( file_exists( self::$active_export_file ) );
+        $this->assertFileExists( self::$active_export_file );
     }
 
@@ -136 +136 @@
         wp_privacy_delete_old_export_files();
 
-        $this->assertTrue( file_exists( self::$index_path ) );
+        $this->assertFileExists( self::$index_path );
     }
 
@@ -148 +148 @@
 
         wp_privacy_delete_old_export_files();
-        $this->assertTrue( file_exists( self::$active_export_file ) );
-        $this->assertTrue( file_exists( self::$expired_export_file ) );
+        $this->assertFileExists( self::$active_export_file );
+        $this->assertFileExists( self::$expired_export_file );
 
         remove_filter( 'wp_privacy_export_expiration', array( $this, 'filter_export_file_expiration_time' ) );

trunk/tests/phpunit/tests/privacy/wpPrivacyGeneratePersonalDataExportFile.php

@@ -290 +290 @@
         wp_privacy_generate_personal_data_export_file( self::$export_request_id );
 
-        $this->assertTrue( file_exists( self::$exports_dir . 'index.php' ) );
+        $this->assertFileExists( self::$exports_dir . 'index.php' );
     }
 
@@ -301 +301 @@
         wp_privacy_generate_personal_data_export_file( self::$export_request_id );
 
-        $this->assertTrue( file_exists( $this->export_file_name ) );
+        $this->assertFileExists( $this->export_file_name );
     }
 
@@ -409 +409 @@
 
         wp_privacy_generate_personal_data_export_file( self::$export_request_id );
-        $this->assertTrue( file_exists( $this->export_file_name ) );
+        $this->assertFileExists( $this->export_file_name );
 
         // Create a temporary export directory for the test's export files.