Changeset 58225 for trunk/tests/phpunit/tests/rest-api/rest-global-styles-revisions-controller.php

Timestamp:

05/28/2024 12:38:28 PM (4 months ago)

Author:

swissspidy

Message:

REST API: Refactor global styles endpoints in REST API to register with post type.

Updated the global styles endpoints in the REST API to extend from existing posts and revisions controllers. This reduces duplicated code and inconsistencies. The revisions controller is now a subclass of the WP_REST_Revisions_Controller. Related redundant methods were removed and schema generation and collection parameters were adjusted to suit the global styles context. Updated permission checks, constructor, and collection parameters accordingly. This change allows for easy override of these classes using the register_post_type_args filter.

This reintroduces [57624] (reverted in [57628]) with improved backward compatibility and further enhancements.

Props ramonopoly, spacedmonkey, mukesh27, swissspidy.
Fixes #60131.

File:

• trunk/tests/phpunit/tests/rest-api/rest-global-styles-revisions-controller.php (modified) (3 diffs)

trunk/tests/phpunit/tests/rest-api/rest-global-styles-revisions-controller.php

@@ -421 +421 @@
     /**
      * @ticket 58524
+     * @ticket 60131
      *
      * @covers WP_REST_Global_Styles_Controller::get_item_permissions_check
@@ -429 +430 @@
         $response = rest_get_server()->dispatch( $request );
 
-        $this->assertErrorResponse( 'rest_cannot_view', $response, 403 );
+        $this->assertErrorResponse( 'rest_cannot_read', $response, 403 );
     }
 
@@ -830 +831 @@
      */
     public function test_context_param() {
-        // Controller does not implement test_context_param().
+        // Controller does not implement get_context_param().
     }