Make WordPress Core


Ignore:
Timestamp:
05/30/2024 01:14:15 AM (12 months ago)
Author:
isabel_brison
Message:

Editor: level global styles specificity at 0-1-0.

Adjusts the block level global styles selectors so they have a consistent specificity of 0-1-0, and adjusts base and layout global style selectors to their minimum required specificity.

Props aaronrobertshaw, isabel_brison, andrewserong, mukesh27.
Fixes #61165.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/block-supports/wpGetLayoutStyle.php

    r55201 r58241  
    1919     * @dataProvider data_wp_get_layout_style
    2020     * @ticket       56467
     21     * @ticket       61165
    2122     *
    2223     * @param array  $args            Dataset to test.
     
    7374                    'gap_value'             => '1em',
    7475                ),
    75                 'expected_output' => '.wp-layout > *{margin-block-start:0;margin-block-end:0;}.wp-layout.wp-layout > * + *{margin-block-start:1em;margin-block-end:0;}',
     76                'expected_output' => '.wp-layout > *{margin-block-start:0;margin-block-end:0;}.wp-layout > * + *{margin-block-start:1em;margin-block-end:0;}',
    7677            ),
    7778            'skip serialization should return empty value' => array(
     
    9091                    'gap_value'             => array( 'top' => '1em' ),
    9192                ),
    92                 'expected_output' => '.wp-layout > *{margin-block-start:0;margin-block-end:0;}.wp-layout.wp-layout > * + *{margin-block-start:1em;margin-block-end:0;}',
     93                'expected_output' => '.wp-layout > *{margin-block-start:0;margin-block-end:0;}.wp-layout > * + *{margin-block-start:1em;margin-block-end:0;}',
    9394            ),
    9495            'constrained layout with sizes'                => array(
     
    129130                    'gap_value'             => '2.5rem',
    130131                ),
    131                 'expected_output' => '.wp-layout > *{margin-block-start:0;margin-block-end:0;}.wp-layout.wp-layout > * + *{margin-block-start:2.5rem;margin-block-end:0;}',
     132                'expected_output' => '.wp-layout > *{margin-block-start:0;margin-block-end:0;}.wp-layout > * + *{margin-block-start:2.5rem;margin-block-end:0;}',
    132133            ),
    133134            'constrained layout with axial block gap support' => array(
     
    140141                    'gap_value'             => array( 'top' => '2.5rem' ),
    141142                ),
    142                 'expected_output' => '.wp-layout > *{margin-block-start:0;margin-block-end:0;}.wp-layout.wp-layout > * + *{margin-block-start:2.5rem;margin-block-end:0;}',
     143                'expected_output' => '.wp-layout > *{margin-block-start:0;margin-block-end:0;}.wp-layout > * + *{margin-block-start:2.5rem;margin-block-end:0;}',
    143144            ),
    144145            'constrained layout with block gap support and spacing preset' => array(
     
    151152                    'gap_value'             => 'var:preset|spacing|50',
    152153                ),
    153                 'expected_output' => '.wp-layout > *{margin-block-start:0;margin-block-end:0;}.wp-layout.wp-layout > * + *{margin-block-start:var(--wp--preset--spacing--50);margin-block-end:0;}',
     154                'expected_output' => '.wp-layout > *{margin-block-start:0;margin-block-end:0;}.wp-layout > * + *{margin-block-start:var(--wp--preset--spacing--50);margin-block-end:0;}',
    154155            ),
    155156            'flex layout with no args should return empty value' => array(
     
    249250                'expected_output' => '.wp-layout{flex-wrap:nowrap;flex-direction:column;align-items:flex-start;justify-content:flex-end;}',
    250251            ),
     252            'default grid layout'                          => array(
     253                'args'            => array(
     254                    'selector' => '.wp-layout',
     255                    'layout'   => array(
     256                        'type' => 'grid',
     257                    ),
     258                ),
     259                'expected_output' => '.wp-layout{grid-template-columns:repeat(auto-fill, minmax(min(12rem, 100%), 1fr));container-type:inline-size;}',
     260            ),
     261            'grid layout with columnCount'                 => array(
     262                'args'            => array(
     263                    'selector' => '.wp-layout',
     264                    'layout'   => array(
     265                        'type'        => 'grid',
     266                        'columnCount' => 3,
     267                    ),
     268                ),
     269                'expected_output' => '.wp-layout{grid-template-columns:repeat(3, minmax(0, 1fr));}',
     270            ),
    251271            'default layout with blockGap to verify converting gap value into valid CSS' => array(
    252272                'args'            => array(
     
    261281                    ),
    262282                ),
    263                 'expected_output' => '.wp-block-group.wp-container-6 > *{margin-block-start:0;margin-block-end:0;}.wp-block-group.wp-container-6.wp-block-group.wp-container-6 > * + *{margin-block-start:var(--wp--preset--spacing--70);margin-block-end:0;}',
     283                'expected_output' => '.wp-block-group.wp-container-6 > *{margin-block-start:0;margin-block-end:0;}.wp-block-group.wp-container-6 > * + *{margin-block-start:var(--wp--preset--spacing--70);margin-block-end:0;}',
    264284            ),
    265285        );
Note: See TracChangeset for help on using the changeset viewer.