Changeset 58243

Timestamp:

05/30/2024 04:08:56 AM (2 years ago)

Author:

isabel_brison

Message:

Editor: Negative margins for alignfull children of blocks with custom padding.

Fixes a condition that was preventing align full blocks to extend full width when their parent block has custom padding.

Props richtabor, isabel_brison, ramonopoly.
Fixes #61313.

File:

• trunk/src/wp-includes/block-supports/layout.php (modified) (2 diffs)

trunk/src/wp-includes/block-supports/layout.php

@@ -225 +225 @@
  * @since 6.3.0 Added grid layout type.
  * @since 6.6.0 Removed duplicated selector from layout styles.
+ *              Enabled negative margins for alignfull children of blocks with custom padding.
  * @access private
  *
@@ -308 +309 @@
                                 )
                         );
-
-                        if ( isset( $block_spacing ) ) {
-                                $block_spacing_values = wp_style_engine_get_styles(
-                                        array(
-                                                'spacing' => $block_spacing,
-                                        )
+                }
+
+                if ( isset( $block_spacing ) ) {
+                        $block_spacing_values = wp_style_engine_get_styles(
+                                array(
+                                        'spacing' => $block_spacing,
+                                )
+                        );
+
+                        /*
+                         * Handle negative margins for alignfull children of blocks with custom padding set.
+                         * They're added separately because padding might only be set on one side.
+                         */
+                        if ( isset( $block_spacing_values['declarations']['padding-right'] ) ) {
+                                $padding_right   = $block_spacing_values['declarations']['padding-right'];
+                                $layout_styles[] = array(
+                                        'selector'     => "$selector > .alignfull",
+                                        'declarations' => array( 'margin-right' => "calc($padding_right * -1)" ),
                                 );
-
-                                /*
-                                 * Handle negative margins for alignfull children of blocks with custom padding set.
-                                 * They're added separately because padding might only be set on one side.
-                                 */
-                                if ( isset( $block_spacing_values['declarations']['padding-right'] ) ) {
-                                        $padding_right   = $block_spacing_values['declarations']['padding-right'];
-                                        $layout_styles[] = array(
-                                                'selector'     => "$selector > .alignfull",
-                                                'declarations' => array( 'margin-right' => "calc($padding_right * -1)" ),
-                                        );
-                                }
-                                if ( isset( $block_spacing_values['declarations']['padding-left'] ) ) {
-                                        $padding_left    = $block_spacing_values['declarations']['padding-left'];
-                                        $layout_styles[] = array(
-                                                'selector'     => "$selector > .alignfull",
-                                                'declarations' => array( 'margin-left' => "calc($padding_left * -1)" ),
-                                        );
-                                }
+                        }
+                        if ( isset( $block_spacing_values['declarations']['padding-left'] ) ) {
+                                $padding_left    = $block_spacing_values['declarations']['padding-left'];
+                                $layout_styles[] = array(
+                                        'selector'     => "$selector > .alignfull",
+                                        'declarations' => array( 'margin-left' => "calc($padding_left * -1)" ),
+                                );
                         }
                 }