Changeset 58255

Timestamp:

05/30/2024 04:19:27 PM (8 months ago)

Author:

hellofromTonya

Message:

Plugin Dependencies: Ensure dependency detection for newly installed plugins.

Resolves a bug by first initializing in the AJAX callback WP_Plugin_Dependencies::check_plugin_dependencies_during_ajax().

More details:

[57658] removed auto-deactivation and bootstrapping logic from the Plugin Dependencies feature. In doing so, initialization calls were added to various locations in Core to ensure dependencies were detected and ready to be checked. However, an initialization call was missed in the AJAX callback before checking plugin dependencies.

This means that a plugin's dependencies may not be detected, and lead to a false positive, which in turn allows the user to click Activate only to see a failure message.

Follow-up to [57658].

Reviewed by jorbin.
Merges [58252] to the 6.5 branch.

Props kevinwhoffman, costdev, afragen.
Fixes #61294.

Location:

branches/6.5

Files:

• . (modified) (1 prop)
• src/wp-includes/class-wp-plugin-dependencies.php (modified) (1 diff)

branches/6.5/src/wp-includes/class-wp-plugin-dependencies.php

@@ -489 +489 @@
         }
 
+        self::initialize();
         $dependencies = self::get_dependencies( $plugin_file );
         if ( empty( $dependencies ) ) {