Changeset 58279

Timestamp:

06/02/2024 08:35:30 AM (2 years ago)

Author:

audrasjb

Message:

Media: Follow the "proximity of controls" accessibility guidelines in the multi-file uploader.

This changeset updates the design of the Upload Media screen to stack progress bars below the file name. After the upload completes, Action buttons also stack below the file name.

Props afercia, rcreators.
Fixes #60141.

Location:

trunk/src

Files:

• js/_enqueues/vendor/plupload/handlers.js (modified) (1 diff)
• wp-admin/async-upload.php (modified) (1 diff)
• wp-admin/css/media.css (modified) (3 diffs)

trunk/src/js/_enqueues/vendor/plupload/handlers.js

@@ -17 +17 @@
                 .attr( 'id', 'media-item-' + fileObj.id )
                 .addClass( 'child-of-' + postid )
-                .append( '<div class="progress"><div class="percent">0%</div><div class="bar"></div></div>',
-                        jQuery( '<div class="filename original">' ).text( ' ' + fileObj.name ) )
+                .append( jQuery( '<div class="filename original">' ).text( ' ' + fileObj.name ),
+                        '<div class="progress"><div class="percent">0%</div><div class="bar"></div></div>' )
                 .appendTo( jQuery( '#media-items' ) );
 

trunk/src/wp-admin/async-upload.php

@@ -66 +66 @@
                                                 <span class="media-list-title"><strong><?php echo esc_html( wp_html_excerpt( $title, 60, '&hellip;' ) ); ?></strong></span>
                                                 <span class="media-list-subtitle"><?php echo esc_html( wp_basename( $file ) ); ?></span>
+                                                <div class="attachment-tools">
+                                                        <?php
+                                                        if ( current_user_can( 'edit_post', $id ) ) {
+                                                                echo '<a class="edit-attachment" href="' . esc_url( get_edit_post_link( $id ) ) . '">' . _x( 'Edit', 'media item' ) . '</a>';
+                                                        } else {
+                                                                echo '<span class="edit-attachment">' . _x( 'Success', 'media item' ) . '</span>';
+                                                        }
+                                                        ?>
+                                                        <span class="media-item-copy-container copy-to-clipboard-container edit-attachment">
+                                                                <button type="button" class="button button-small copy-attachment-url" data-clipboard-text="<?php echo $file_url; ?>"><?php _e( 'Copy URL to clipboard' ); ?></button>
+                                                                <span class="success hidden" aria-hidden="true"><?php _e( 'Copied!' ); ?></span>
+                                                        </span>
+                                                </div>
                                         </div>
-                                </div>
-                                <div class="attachment-tools">
-                                        <span class="media-item-copy-container copy-to-clipboard-container edit-attachment">
-                                                <button type="button" class="button button-small copy-attachment-url" data-clipboard-text="<?php echo esc_url( $file_url ); ?>"><?php _e( 'Copy URL to clipboard' ); ?></button>
-                                                <span class="success hidden" aria-hidden="true"><?php _e( 'Copied!' ); ?></span>
-                                        </span>
-                                        <?php
-                                        if ( current_user_can( 'edit_post', $id ) ) {
-                                                echo '<a class="edit-attachment" href="' . esc_url( get_edit_post_link( $id ) ) . '">' . _x( 'Edit', 'media item' ) . '</a>';
-                                        } else {
-                                                echo '<span class="edit-attachment">' . _x( 'Success', 'media item' ) . '</span>';
-                                        }
-                                        ?>
                                 </div>
                         </div>

trunk/src/wp-admin/css/media.css

@@ -113 +113 @@
 }
 
-.media-item-wrapper {
-        display: grid;
-        grid-template-columns: 1fr 1fr;
-}
-
 .media-item .attachment-tools {
         display: flex;
-        justify-content: flex-end;
         align-items: center;
 }
@@ -191 +185 @@
 }
 
-.media-item .original {
-        position: relative;
-        min-height: 34px;
-}
-
 .media-item .progress {
-        float: right;
+        display: inline-block;
         height: 22px;
-        margin: 7px 6px;
+        margin: 0 6px 7px;
         width: 200px;
         line-height: 2em;
@@ -1437 +1426 @@
         }
 }
+
+@media only screen and (max-width: 375px) {
+        .media-item .attachment-tools {
+                align-items: baseline;
+        }
+        .media-item .edit-attachment.copy-to-clipboard-container {
+                flex-direction: column;
+        }
+
+        .copy-to-clipboard-container .success {
+                line-height: normal;
+                margin-top: 10px;
+        }
+}