Changeset 58286 for trunk/src/wp-includes/embed.php

Timestamp:

06/02/2024 10:00:26 PM (11 months ago)

Author:

audrasjb

Message:

Embeds: Add titles to alternate resource links for oEmbed and REST API.

This changeset makes the following changes:

• Adds the title attribute to <link rel="alternate"> tags for oEmbed and REST API endpoints
• Updates the oEmbed phpunit tests to reflect the above change
• Adds the title link-param to REST API Link: headers (verified as supported in RFC 8288 here: ​https://httpwg.org/specs/rfc8288.html#serialisation-defined-attributes)

Props edent, kadamwhite, TimothyBlynJacobs, joedolson, swissspidy, sabernhardt.
Fixes #59006.

File:

• trunk/src/wp-includes/embed.php (modified) (1 diff)

trunk/src/wp-includes/embed.php

@@ -337 +337 @@
 
     if ( is_singular() ) {
-        $output .= '<link rel="alternate" type="application/json+oembed" href="' . esc_url( get_oembed_endpoint_url( get_permalink() ) ) . '" />' . "\n";
+        $output .= '<link rel="alternate" title="' . _x( 'oEmbed (JSON)', 'oEmbed resource link name' ) . '" type="application/json+oembed" href="' . esc_url( get_oembed_endpoint_url( get_permalink() ) ) . '" />' . "\n";
 
         if ( class_exists( 'SimpleXMLElement' ) ) {
-            $output .= '<link rel="alternate" type="text/xml+oembed" href="' . esc_url( get_oembed_endpoint_url( get_permalink(), 'xml' ) ) . '" />' . "\n";
+            $output .= '<link rel="alternate" title="' . _x( 'oEmbed (XML)', 'oEmbed resource link name' ) . '" type="text/xml+oembed" href="' . esc_url( get_oembed_endpoint_url( get_permalink(), 'xml' ) ) . '" />' . "\n";
         }
     }