Changeset 58286 for trunk/tests/phpunit/tests/oembed/discovery.php

Timestamp:

06/02/2024 10:00:26 PM (14 months ago)

Author:

audrasjb

Message:

Embeds: Add titles to alternate resource links for oEmbed and REST API.

This changeset makes the following changes:

• Adds the title attribute to <link rel="alternate"> tags for oEmbed and REST API endpoints
• Updates the oEmbed phpunit tests to reflect the above change
• Adds the title link-param to REST API Link: headers (verified as supported in RFC 8288 here: ​https://httpwg.org/specs/rfc8288.html#serialisation-defined-attributes)

Props edent, kadamwhite, TimothyBlynJacobs, joedolson, swissspidy, sabernhardt.
Fixes #59006.

File:

• trunk/tests/phpunit/tests/oembed/discovery.php (modified) (4 diffs)

trunk/tests/phpunit/tests/oembed/discovery.php

@@ -33 +33 @@
         $this->assertQueryTrue( 'is_front_page', 'is_singular', 'is_page' );
 
-        $expected  = '<link rel="alternate" type="application/json+oembed" href="' . esc_url( get_oembed_endpoint_url( get_permalink() ) ) . '" />' . "\n";
-        $expected .= '<link rel="alternate" type="text/xml+oembed" href="' . esc_url( get_oembed_endpoint_url( get_permalink(), 'xml' ) ) . '" />' . "\n";
+        $expected  = '<link rel="alternate" title="oEmbed (JSON)" type="application/json+oembed" href="' . esc_url( get_oembed_endpoint_url( get_permalink() ) ) . '" />' . "\n";
+        $expected .= '<link rel="alternate" title="oEmbed (XML)" type="text/xml+oembed" href="' . esc_url( get_oembed_endpoint_url( get_permalink(), 'xml' ) ) . '" />' . "\n";
 
         $this->assertSame( $expected, get_echo( 'wp_oembed_add_discovery_links' ) );
@@ -46 +46 @@
         $this->assertQueryTrue( 'is_single', 'is_singular' );
 
-        $expected  = '<link rel="alternate" type="application/json+oembed" href="' . esc_url( get_oembed_endpoint_url( get_permalink() ) ) . '" />' . "\n";
-        $expected .= '<link rel="alternate" type="text/xml+oembed" href="' . esc_url( get_oembed_endpoint_url( get_permalink(), 'xml' ) ) . '" />' . "\n";
+        $expected  = '<link rel="alternate" title="oEmbed (JSON)" type="application/json+oembed" href="' . esc_url( get_oembed_endpoint_url( get_permalink() ) ) . '" />' . "\n";
+        $expected .= '<link rel="alternate" title="oEmbed (XML)" type="text/xml+oembed" href="' . esc_url( get_oembed_endpoint_url( get_permalink(), 'xml' ) ) . '" />' . "\n";
 
         $this->assertSame( $expected, get_echo( 'wp_oembed_add_discovery_links' ) );
@@ -61 +61 @@
         $this->assertQueryTrue( 'is_page', 'is_singular' );
 
-        $expected  = '<link rel="alternate" type="application/json+oembed" href="' . esc_url( get_oembed_endpoint_url( get_permalink() ) ) . '" />' . "\n";
-        $expected .= '<link rel="alternate" type="text/xml+oembed" href="' . esc_url( get_oembed_endpoint_url( get_permalink(), 'xml' ) ) . '" />' . "\n";
+        $expected  = '<link rel="alternate" title="oEmbed (JSON)" type="application/json+oembed" href="' . esc_url( get_oembed_endpoint_url( get_permalink() ) ) . '" />' . "\n";
+        $expected .= '<link rel="alternate" title="oEmbed (XML)" type="text/xml+oembed" href="' . esc_url( get_oembed_endpoint_url( get_permalink(), 'xml' ) ) . '" />' . "\n";
 
         $this->assertSame( $expected, get_echo( 'wp_oembed_add_discovery_links' ) );
@@ -81 +81 @@
         $this->assertQueryTrue( 'is_attachment', 'is_singular', 'is_single' );
 
-        $expected  = '<link rel="alternate" type="application/json+oembed" href="' . esc_url( get_oembed_endpoint_url( get_permalink() ) ) . '" />' . "\n";
-        $expected .= '<link rel="alternate" type="text/xml+oembed" href="' . esc_url( get_oembed_endpoint_url( get_permalink(), 'xml' ) ) . '" />' . "\n";
+        $expected  = '<link rel="alternate" title="oEmbed (JSON)" type="application/json+oembed" href="' . esc_url( get_oembed_endpoint_url( get_permalink() ) ) . '" />' . "\n";
+        $expected .= '<link rel="alternate" title="oEmbed (XML)" type="text/xml+oembed" href="' . esc_url( get_oembed_endpoint_url( get_permalink(), 'xml' ) ) . '" />' . "\n";
 
         $this->assertSame( $expected, get_echo( 'wp_oembed_add_discovery_links' ) );