Changeset 58335 for trunk/src/wp-includes/comment-template.php

Timestamp:

06/04/2024 03:27:57 PM (21 months ago)

Author:

SergeyBiryukov

Message:

Comments: Ensure the correct comment ID type is passed to get_comment_author.

The $comment_id parameter of the get_comment_author filter is documented as a numeric string, however in case a non-existing comment ID is passed to the get_comment_author() function, it could be an integer instead.

This commit resolves the issue and adds a PHPUnit test demonstrating the behavior.

Includes updating get_comment_author_url() unit tests for consistency.

Follow-up to [41127], [52818].

Props david.binda.
Fixes #60475.

File:

• trunk/src/wp-includes/comment-template.php (modified) (1 diff)

trunk/src/wp-includes/comment-template.php

@@ -25 +25 @@
     $comment = get_comment( $comment_id );
 
-    $comment_id = ! empty( $comment->comment_ID ) ? $comment->comment_ID : $comment_id;
+    $comment_id = ! empty( $comment->comment_ID ) ? $comment->comment_ID : (string) $comment_id;
 
     if ( empty( $comment->comment_author ) ) {