Changeset 58340 for trunk/tests/phpunit/tests/rest-api/rest-schema-setup.php

Timestamp:

06/05/2024 11:53:31 AM (2 years ago)

Author:

oandregal

Message:

REST API: improve code quality for class_list field fixtures.

Follow-up to [58326], #61360.

Props antonvlasenko, oandregal.
Fixes #61369.

File:

• trunk/tests/phpunit/tests/rest-api/rest-schema-setup.php (modified) (7 diffs)

trunk/tests/phpunit/tests/rest-api/rest-schema-setup.php

@@ -578 +578 @@
                 'oembeds.html'                                     => '<blockquote class="wp-embedded-content">...</blockquote>...',
                 'PostsCollection.0.id'                             => 4,
+                'PostsCollection.0.class_list.0'                   => 'post-4',
                 'PostsCollection.0.guid.rendered'                  => 'http://example.org/?p=4',
                 'PostsCollection.0.link'                           => 'http://example.org/?p=4',
@@ -591 +592 @@
                 'PostsCollection.0._links.wp:term.1.href'          => 'http://example.org/index.php?rest_route=%2Fwp%2Fv2%2Ftags&post=4',
                 'PostModel.id'                                     => 4,
+                'PostModel.class_list.0'                           => 'post-4',
                 'PostModel.guid.rendered'                          => 'http://example.org/?p=4',
                 'PostModel.link'                                   => 'http://example.org/?p=4',
@@ -622 +624 @@
                 'autosave.guid.rendered'                           => 'http://example.org/?p=6',
                 'PagesCollection.0.id'                             => 7,
+                'PagesCollection.0.class_list.0'                   => 'post-7',
                 'PagesCollection.0.guid.rendered'                  => 'http://example.org/?page_id=7',
                 'PagesCollection.0.link'                           => 'http://example.org/?page_id=7',
@@ -633 +636 @@
                 'PagesCollection.0._links.wp:attachment.0.href'    => 'http://example.org/index.php?rest_route=%2Fwp%2Fv2%2Fmedia&parent=7',
                 'PageModel.id'                                     => 7,
+                'PageModel.class_list.0'                           => 'post-7',
                 'PageModel.guid.rendered'                          => 'http://example.org/?page_id=7',
                 'PageModel.link'                                   => 'http://example.org/?page_id=7',
@@ -664 +668 @@
                 'pageAutosave.guid.rendered'                       => 'http://example.org/?p=9',
                 'MediaCollection.0.id'                             => 10,
+                'MediaCollection.0.class_list.0'                   => 'post-10',
                 'MediaCollection.0.guid.rendered'                  => 'http://example.org/?attachment_id=10',
                 'MediaCollection.0.link'                           => 'http://example.org/?attachment_id=10',
@@ -673 +678 @@
                 'MediaCollection.0._links.replies.0.href'          => 'http://example.org/index.php?rest_route=%2Fwp%2Fv2%2Fcomments&post=10',
                 'MediaModel.id'                                    => 10,
+                'MediaModel.class_list.0'                          => 'post-10',
                 'MediaModel.guid.rendered'                         => 'http://example.org/?attachment_id=10',
                 'MediaModel.link'                                  => 'http://example.org/?attachment_id=10',
@@ -763 +769 @@
 
                 foreach ( $data as $key => $value ) {
-                        if ( is_string( $value ) ) {
-                                if ( in_array( $key, $datetime_keys, true ) ) {
-                                        $data[ $key ] = '2017-02-14T00:00:00';
-                                        continue;
-                                }
-
-                                if ( 1 === preg_match( '/^post-\d+$/', $value ) ) {
-                                        // Normalize the class value to ensure test stability.
-                                        $data[ $key ] = 'post-1073';
-                                        continue;
-                                }
+                        if ( is_string( $value ) && in_array( $key, $datetime_keys, true ) ) {
+                                $data[ $key ] = '2017-02-14T00:00:00';
+                                continue;
                         }