Changeset 58345

Timestamp:

06/05/2024 06:23:08 PM (4 months ago)

Author:

desrosj

Message:

Build/Test Tools: Simplify inputs for build process testing.

This introduces a new input to separate the ability to save the built WordPress ZIP from generating the artifacts necessary for comments with Playground testing details.

The ZIP file is used by the performance testing workflow for performing comparisons, so it should be built and saved for every push event. The Playground related steps should only run on pull_request.

Follow up to [58274].

Props jorbin.
See #59416.

Location:

trunk/.github/workflows

Files:

• reusable-test-core-build-process.yml (modified) (3 diffs)
• test-build-processes.yml (modified) (1 diff)

trunk/.github/workflows/reusable-test-core-build-process.yml

@@ -22 +22 @@
         type: 'boolean'
         default: true
+      save-build:
+        description: 'Whether to save a ZIP of built WordPress as an artifact.'
+        required: false
+        type: 'boolean'
+        default: false
       prepare-playground:
         description: 'Whether to prepare the artifacts needed for Playground testing.'
@@ -98 +103 @@
       - name: Upload ZIP as a GitHub Actions artifact
         uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
-        if: ${{ inputs.prepare-playground }}
+        if: ${{ inputs.save-build || inputs.prepare-playground }}
         with:
           name: wordpress-build-${{ github.event_name == 'pull_request' && github.event.number || github.sha }}
@@ -105 +110 @@
 
       - name: Save PR number
-        if: ${{ inputs.prepare-playground && github.repository == 'WordPress/wordpress-develop' && github.event_name == 'pull_request' }}
+        if: ${{ inputs.prepare-playground }}
         run: |
           mkdir -p ./pr-number

trunk/.github/workflows/test-build-processes.yml

@@ -45 +45 @@
           - os: ubuntu-latest
             directory: 'build'
-            prepare-playground: true
+            save-build: true
+            prepare-playground: ${{ github.event_name == 'pull_request' && true || '' }}
+
     with:
       os: ${{ matrix.os }}
       directory: ${{ matrix.directory }}
+      save-build: ${{ matrix.save-build && matrix.save-build || false }}
       prepare-playground: ${{ matrix.prepare-playground && matrix.prepare-playground || false }}