Changeset 58366

Timestamp:

06/08/2024 04:21:49 PM (11 months ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Use strict comparison in wp-includes/theme.php.

Follow-up to [12025], [14850], [15641], [20029], [22436], [35738], [36915], [58213].

Props aristath, poena, afercia, SergeyBiryukov.
See #60700.

File:

• trunk/src/wp-includes/theme.php (modified) (6 diffs)

trunk/src/wp-includes/theme.php

@@ -92 +92 @@
     if ( null !== $args['errors'] ) {
         foreach ( $themes as $theme => $wp_theme ) {
-            if ( $wp_theme->errors() != $args['errors'] ) {
+            if ( (bool) $wp_theme->errors() !== $args['errors'] ) {
                 unset( $themes[ $theme ] );
             }
@@ -578 +578 @@
     }
 
-    if ( get_site_transient( 'theme_roots' ) != $theme_roots ) {
+    if ( get_site_transient( 'theme_roots' ) !== $theme_roots ) {
         set_site_transient( 'theme_roots', $theme_roots, $cache_expiration );
     }
@@ -706 +706 @@
     // If requesting the root for the active theme, consult options to avoid calling get_theme_roots().
     if ( ! $skip_cache ) {
-        if ( get_option( 'stylesheet' ) == $stylesheet_or_template ) {
+        if ( get_option( 'stylesheet' ) === $stylesheet_or_template ) {
             $theme_root = get_option( 'stylesheet_root' );
-        } elseif ( get_option( 'template' ) == $stylesheet_or_template ) {
+        } elseif ( get_option( 'template' ) === $stylesheet_or_template ) {
             $theme_root = get_option( 'template_root' );
         }
@@ -943 +943 @@
      */
     $default = WP_Theme::get_core_default_theme();
-    if ( false === $default || get_stylesheet() == $default->get_stylesheet() ) {
+    if ( false === $default || get_stylesheet() === $default->get_stylesheet() ) {
         return true;
     }
@@ -1568 +1568 @@
                 foreach ( (array) $_wp_default_headers as $default_header ) {
                     $url = vsprintf( $default_header['url'], $directory_args );
-                    if ( $data['url'] == $url ) {
+                    if ( $data['url'] === $url ) {
                         $data                  = $default_header;
                         $data['url']           = $url;
@@ -3445 +3445 @@
     $header_image     = get_header_image();
     $background_image = get_background_image();
-    $custom_logo_id   = get_theme_mod( 'custom_logo' );
-    $site_logo_id     = get_option( 'site_logo' );
-
-    if ( $custom_logo_id && $custom_logo_id == $id ) {
+    $custom_logo_id   = (int) get_theme_mod( 'custom_logo' );
+    $site_logo_id     = (int) get_option( 'site_logo' );
+
+    if ( $custom_logo_id && $custom_logo_id === $id ) {
         remove_theme_mod( 'custom_logo' );
         remove_theme_mod( 'header_text' );
     }
 
-    if ( $site_logo_id && $site_logo_id == $id ) {
+    if ( $site_logo_id && $site_logo_id === $id ) {
         delete_option( 'site_logo' );
     }
 
-    if ( $header_image && $header_image == $attachment_image ) {
+    if ( $header_image && $header_image === $attachment_image ) {
         remove_theme_mod( 'header_image' );
         remove_theme_mod( 'header_image_data' );
     }
 
-    if ( $background_image && $background_image == $attachment_image ) {
+    if ( $background_image && $background_image === $attachment_image ) {
         remove_theme_mod( 'background_image' );
     }