Changeset 58379 for trunk/src/wp-admin/includes/class-wp-list-table.php

Timestamp:

06/11/2024 02:12:52 AM (13 months ago)

Author:

peterwilsoncc

Message:

Administration: Prevent an orderby array throwing a notice.

Prevent WP_List_Table::search_box() from throwing an array to string conversion notice when post list tables are loaded with an array of orderby parameters in the URL, eg: /wp-admin/edit.php?post_type=page&orderby[menu_order]=ASC&orderby[title]=ASC.

Follow up to [29027].

Props leonidasmilossis, rajinsharwar, swissspidy, NomNom99, pls78, SergeyBiryukov.
Fixes #59494.
See #17065.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -389 +389 @@
 
         if ( ! empty( $_REQUEST['orderby'] ) ) {
-            echo '<input type="hidden" name="orderby" value="' . esc_attr( $_REQUEST['orderby'] ) . '" />';
+            if ( is_array( $_REQUEST['orderby'] ) ) {
+                foreach ( $_REQUEST['orderby'] as $key => $value ) {
+                    /*
+                     * Orderby can be either an associative array or non-associative array.
+                     * In the latter case, this makes sure the key is a string before calling esc_attr().
+                     */
+                    $key = (string) $key;
+                    echo '<input type="hidden" name="orderby[' . esc_attr( $key ) . ']" value="' . esc_attr( $value ) . '" />';
+                }
+            } else {
+                echo '<input type="hidden" name="orderby" value="' . esc_attr( $_REQUEST['orderby'] ) . '" />';
+            }
         }
         if ( ! empty( $_REQUEST['order'] ) ) {