Changeset 5838

Timestamp:

08/01/2007 08:58:38 PM (18 years ago)

Author:

markjaquith

Message:

More upload escaping. Props Brian Layman. fixes #4689 for 2.2.x

File:

• branches/2.2/wp-admin/upload-functions.php (modified) (4 diffs)

branches/2.2/wp-admin/upload-functions.php

@@ -108 +108 @@
     $post_id = (int) $post_id;
 ?>
-    <form<?php echo $enctype; ?> id="upload-file" method="post" action="<?php echo get_option('siteurl') . '/wp-admin/upload.php?style=' . attribute_escape($style) . '&amp;tab=upload&amp;post_id=' . $post_id; ?>">
+    <form<?php echo $enctype; ?> id="upload-file" method="post" action="<?php echo get_option('siteurl') . '/wp-admin/upload.php?style=' . attribute_escape($style . '&amp;tab=upload&amp;post_id=' . $post_id); ?>">
 <?php
     if ( $id ) :
@@ -203 +203 @@
         if ( !current_user_can( 'upload_files' ) )
             wp_die( __('You are not allowed to upload files.')
-                . " <a href='" . get_option('siteurl') . "/wp-admin/upload.php?style=$style&amp;tab=browse-all&amp;post_id=$post_id'>"
+                . " <a href='" . get_option('siteurl') . "/wp-admin/upload.php?style=" . attribute_escape($style . "&amp;tab=browse-all&amp;post_id=$post_id") . "'>"
                 . __('Browse Files') . '</a>'
             );
@@ -213 +213 @@
         if ( isset($file['error']) )
             wp_die($file['error'] . "<br /><a href='" . get_option('siteurl')
-            . "/wp-admin/upload.php?style=$style&amp;tab=$from_tab&amp;post_id=$post_id'>" . __('Back to Image Uploading') . '</a>'
+            . "/wp-admin/upload.php?style=" . attribute_escape($style . "&amp;tab=$from_tab&amp;post_id=$post_id") . "'>" . __('Back to Image Uploading') . '</a>'
         );
 
@@ -260 +260 @@
         if ( !current_user_can('edit_post', (int) $ID) )
             wp_die( __('You are not allowed to delete this attachment.')
-                . " <a href='" . get_option('siteurl') . "/wp-admin/upload.php?style=$style&amp;tab=$from_tab&amp;post_id=$post_id'>"
+                . " <a href='" . get_option('siteurl') . "/wp-admin/upload.php?style=" . attribute_escape($style . "&amp;tab=$from_tab&amp;post_id=$post_id") . "'>"
                 . __('Go back') . '</a>'
             );