Changeset 58389 for trunk/src/wp-admin/includes/class-wp-list-table.php

Timestamp:

06/11/2024 12:36:13 PM (2 years ago)

Author:

SergeyBiryukov

Message:

Administration: Remove redundant type casting in WP_List_Table::search_box().

Scalar values passed to esc_attr() are already converted internally to a string via both wp_check_invalid_utf8() and _wp_specialchars().

Includes adding @covers tags for unit tests.

Follow-up to [58379].

See #58379.

File:

• trunk/src/wp-admin/includes/class-wp-list-table.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-list-table.php

@@ -391 +391 @@
                         if ( is_array( $_REQUEST['orderby'] ) ) {
                                 foreach ( $_REQUEST['orderby'] as $key => $value ) {
-                                        /*
-                                         * Orderby can be either an associative array or non-associative array.
-                                         * In the latter case, this makes sure the key is a string before calling esc_attr().
-                                         */
-                                        $key = (string) $key;
                                         echo '<input type="hidden" name="orderby[' . esc_attr( $key ) . ']" value="' . esc_attr( $value ) . '" />';
                                 }