Changeset 58407

Timestamp:

06/13/2024 02:46:08 PM (4 months ago)

Author:

joedolson

Message:

Themes: Fix attachment rendered as site logo on attachment page.

Fix issue where the attachment thumbnail would be rendered as the site logo on attachment single templates if no site logo is set. Avoid calling wp_attachment_is_image() with no value, since that function will fallback to the global $post variable. Follow up to [58213]. See #60922.

Props greenshady, krupajnanda, hmbashar, rajinsharwar, joedolson.
Fixes #61408.

File:

• trunk/src/wp-includes/general-template.php (modified) (1 diff)

trunk/src/wp-includes/general-template.php

@@ -1036 +1036 @@
 
     $custom_logo_id = get_theme_mod( 'custom_logo' );
-    $is_image       = wp_attachment_is_image( $custom_logo_id );
+    $is_image       = ( $custom_logo_id ) ? wp_attachment_is_image( $custom_logo_id ) : false;
 
     if ( $switched_blog ) {