Changeset 58409 for trunk/src/wp-includes/formatting.php

Timestamp:

06/13/2024 08:48:33 PM (10 months ago)

Author:

hellofromTonya

Message:

Code Modernization: Use wp_trigger_error() instead of trigger_error().

Replaces trigger_error() with wp_trigger_error().

The usage of wp_trigger_error() avoids generating E_USER family errors unless WP_DEBUG is on. In doing so, users should not see these messages in normal production.

Notes:

• Removes E_USER_NOTICE when passed as an argumnent, as it's the default error level.
• An empty string is passed for the function name when its name is already in the error message or does not add value to the error message.
• Externally maintained libraries are not included.

Follow-up to [55204], [25956], [29630], [38883], [52062], [52049], [54272], [38883], [55245], [51599], [14452], [38883], [24976].

Props prasadkarmalkar, rajinsharwar, thelovekesh, hellofromTonya, swissspidy.
Fixes #59652.

File:

• trunk/src/wp-includes/formatting.php (modified) (1 diff)

trunk/src/wp-includes/formatting.php

@@ -5519 +5519 @@
         /*
          * To maintain consistency with pre-PHP 8 error levels,
-         * trigger_error() is used to trigger an E_USER_WARNING,
+         * wp_trigger_error() is used to trigger an E_USER_WARNING,
          * rather than _doing_it_wrong(), which triggers an E_USER_NOTICE.
          */
-        trigger_error(
+        wp_trigger_error(
+            '',
             sprintf(
                 /* translators: 1: The function name, 2: The argument number, 3: The argument name, 4: The expected type, 5: The provided type. */