Changeset 58409 for trunk/src/wp-includes/rss.php

Timestamp:

06/13/2024 08:48:33 PM (11 months ago)

Author:

hellofromTonya

Message:

Code Modernization: Use wp_trigger_error() instead of trigger_error().

Replaces trigger_error() with wp_trigger_error().

The usage of wp_trigger_error() avoids generating E_USER family errors unless WP_DEBUG is on. In doing so, users should not see these messages in normal production.

Notes:

• Removes E_USER_NOTICE when passed as an argumnent, as it's the default error level.
• An empty string is passed for the function name when its name is already in the error message or does not add value to the error message.
• Externally maintained libraries are not included.

Follow-up to [55204], [25956], [29630], [38883], [52062], [52049], [54272], [38883], [55245], [51599], [14452], [38883], [24976].

Props prasadkarmalkar, rajinsharwar, thelovekesh, hellofromTonya, swissspidy.
Fixes #59652.

File:

• trunk/src/wp-includes/rss.php (modified) (3 diffs)

trunk/src/wp-includes/rss.php

@@ -64 +64 @@
         #
         if ( ! function_exists('xml_parser_create') ) {
-            return trigger_error( "PHP's XML extension is not available. Please contact your hosting provider to enable PHP's XML extension." );
+            wp_trigger_error( '', "PHP's XML extension is not available. Please contact your hosting provider to enable PHP's XML extension." );
+            return;
         }
 
@@ -388 +389 @@
     function error( $errormsg, $lvl = E_USER_WARNING ) {
         if ( MAGPIE_DEBUG ) {
-            trigger_error( $errormsg, $lvl);
+            wp_trigger_error('', $errormsg, $lvl);
         } else {
             error_log( $errormsg, 0);
@@ -824 +825 @@
         $this->ERROR = $errormsg;
         if ( MAGPIE_DEBUG ) {
-            trigger_error( $errormsg, $lvl);
+            wp_trigger_error( '', $errormsg, $lvl);
         }
         else {