Changeset 58409 for trunk/src/wp-includes/theme.php

Timestamp:

06/13/2024 08:48:33 PM (10 months ago)

Author:

hellofromTonya

Message:

Code Modernization: Use wp_trigger_error() instead of trigger_error().

Replaces trigger_error() with wp_trigger_error().

The usage of wp_trigger_error() avoids generating E_USER family errors unless WP_DEBUG is on. In doing so, users should not see these messages in normal production.

Notes:

• Removes E_USER_NOTICE when passed as an argumnent, as it's the default error level.
• An empty string is passed for the function name when its name is already in the error message or does not add value to the error message.
• Externally maintained libraries are not included.

Follow-up to [55204], [25956], [29630], [38883], [52062], [52049], [54272], [38883], [55245], [51599], [14452], [38883], [24976].

Props prasadkarmalkar, rajinsharwar, thelovekesh, hellofromTonya, swissspidy.
Fixes #59652.

File:

• trunk/src/wp-includes/theme.php (modified) (2 diffs)

trunk/src/wp-includes/theme.php

@@ -515 +515 @@
         $dirs = @ scandir( $theme_root );
         if ( ! $dirs ) {
-            trigger_error( "$theme_root is not readable", E_USER_NOTICE );
+            wp_trigger_error( __FUNCTION__, "$theme_root is not readable" );
             continue;
         }
@@ -539 +539 @@
                 $sub_dirs = @ scandir( $theme_root . '/' . $dir );
                 if ( ! $sub_dirs ) {
-                    trigger_error( "$theme_root/$dir is not readable", E_USER_NOTICE );
+                    wp_trigger_error( __FUNCTION__, "$theme_root/$dir is not readable" );
                     continue;
                 }