Changeset 58416

Timestamp:

06/14/2024 03:19:20 PM (2 years ago)

Author:

joemcgill

Message:

Options: Fix some default autoload values used in core.

This fixes some autoload values that were updated in [58105] that used the database values of "on" and "off" instead of the boolean values true and false when being passed to add|update_option().

Props joemcgill, desrosj, rajinsharwar.
Fixes #61045. See #42441.

Location:

trunk/src

Files:

• wp-admin/includes/ajax-actions.php (modified) (3 diffs)
• wp-includes/option.php (modified) (4 diffs)

trunk/src/wp-admin/includes/ajax-actions.php

@@ -193 +193 @@
                         update_site_option( 'can_compress_scripts', 0 );
                 } else {
-                        update_option( 'can_compress_scripts', 0, 'on' );
+                        update_option( 'can_compress_scripts', 0, true );
                 }
                 wp_die( 0 );
@@ -232 +232 @@
                                 update_site_option( 'can_compress_scripts', 0 );
                         } else {
-                                update_option( 'can_compress_scripts', 0, 'on' );
+                                update_option( 'can_compress_scripts', 0, true );
                         }
                 } elseif ( 'yes' === $_GET['test'] ) {
@@ -240 +240 @@
                                 update_site_option( 'can_compress_scripts', 1 );
                         } else {
-                                update_option( 'can_compress_scripts', 1, 'on' );
+                                update_option( 'can_compress_scripts', 1, true );
                         }
                 }

trunk/src/wp-includes/option.php

@@ -1515 +1515 @@
 
                 if ( false === get_option( $transient_option ) ) {
-                        $autoload = 'on';
+                        $autoload = true;
                         if ( $expiration ) {
-                                $autoload = 'off';
-                                add_option( $transient_timeout, time() + $expiration, '', 'off' );
+                                $autoload = false;
+                                add_option( $transient_timeout, time() + $expiration, '', false );
                         }
                         $result = add_option( $transient_option, $value, '', $autoload );
@@ -1531 +1531 @@
                                 if ( false === get_option( $transient_timeout ) ) {
                                         delete_option( $transient_option );
-                                        add_option( $transient_timeout, time() + $expiration, '', 'off' );
-                                        $result = add_option( $transient_option, $value, '', 'off' );
+                                        add_option( $transient_timeout, time() + $expiration, '', false );
+                                        $result = add_option( $transient_option, $value, '', false );
                                         $update = false;
                                 } else {
@@ -2120 +2120 @@
 
         if ( ! is_multisite() ) {
-                $result = add_option( $option, $value, '', 'off' );
+                $result = add_option( $option, $value, '', false );
         } else {
                 $cache_key = "$network_id:$option";
@@ -2366 +2366 @@
 
         if ( ! is_multisite() ) {
-                $result = update_option( $option, $value, 'off' );
+                $result = update_option( $option, $value, false );
         } else {
                 $value = sanitize_option( $option, $value );