Changeset 58437

Timestamp:

06/18/2024 02:44:23 PM (4 months ago)

Author:

hellofromTonya

Message:

Code Modernization: Fix non-nullable deprecation in get_available_post_mime_types().

Fixes a PHP 8.1 and above "null to non-nullable" deprecation notice in get_available_post_mime_types():

Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in ./wp-includes/post.php on line 3395

​This function is documented to:

• Return An array of MIME types.
• as an array of strings, i.e. string[].

A null or empty element within the returned array is not a valid MIME type. If a null exists in the returned array, it is the root cause of PHP throwing the deprecation notice.

This commit removes the null and empty elements from the returned array of MIME types. It also adds a unit test.

Follow-up to [56623], [56452].

Props nosilver4u, jrf, ironprogrammer, antpb, antonvlasenko, rajinsharwar, hellofromTonya.
Fixes #59195.

Location:

trunk

Files:

• src/wp-includes/post.php (modified) (1 diff)
• tests/phpunit/tests/post/getAvailablePostMimeTypes.php (added)

trunk/src/wp-includes/post.php

@@ -8095 +8095 @@
 
     if ( ! is_array( $mime_types ) ) {
-        $mime_types = $wpdb->get_col( $wpdb->prepare( "SELECT DISTINCT post_mime_type FROM $wpdb->posts WHERE post_type = %s", $type ) );
-    }
-
-    return $mime_types;
+        $mime_types = $wpdb->get_col( $wpdb->prepare( "SELECT DISTINCT post_mime_type FROM $wpdb->posts WHERE post_type = %s AND post_mime_type != ''", $type ) );
+    }
+
+    // Remove nulls from returned $mime_types.
+    return array_values( array_filter( $mime_types ) );
 }