Changeset 5844

Timestamp:

08/03/2007 01:08:59 AM (17 years ago)

Author:

markjaquith

Message:

More streamlined install process. Obeys WP_SITEURL if defined. fixes #4687 (props JeremyVisser, Nazgul), see #4685

Location:

trunk

Files:

• wp-admin/install.php (modified) (4 diffs)
• wp-settings.php (modified) (1 diff)

trunk/wp-admin/install.php

@@ -33 +33 @@
 switch($step) {
     case 0:
+    case 1: // in case people are directly linking to this
 ?>
-<p><?php printf(__('Welcome to WordPress installation. We&#8217;re now going to go through a few steps to get you up and running with the latest in personal publishing platforms. You may want to peruse the <a href="%s">ReadMe documentation</a> at your leisure.'), '../readme.html'); ?></p>
-<h2 class="step"><a href="install.php?step=1"><?php _e('First Step &raquo;'); ?></a></h2>
-<?php
-        break;
-    case 1:
-?>
-<h1><?php _e('First Step'); ?></h1>
-<p><?php _e("Before we begin we need a little bit of information. Don't worry, you can always change these later."); ?></p>
+<h1>Welcome</h1>
+<p><?php printf(__('Welcome to the famous five minute WordPress installation process! You may want to browse the <a href="%s">ReadMe documentation</a> at your leisure.  Otherwise, just fill in the information below and you\'ll be on your way to using the most extendable and powerful personal publishing platform in the world.'), '../readme.html'); ?></p>
+<!--<h2 class="step"><a href="install.php?step=1"><?php _e('First Step &raquo;'); ?></a></h2>-->
+
+<h1><?php _e('Information needed'); ?></h1>
+<p><?php _e("Please provide the following information.  Don't worry, you can always change these settings later."); ?></p>
 
 <form id="setup" method="post" action="install.php?step=2">
@@ -55 +54 @@
         <tr>
             <th scope="row"  valign="top"> <?php __('Privacy:'); ?></th>
-            <td><label><input type="checkbox" name="blog_public" value="1" checked="checked" /> <?php _e('I would like my blog to appear in search engines like Google and Technorati.'); ?></label></td>
+            <td><label><input type="checkbox" name="blog_public" value="1" checked="checked" /> <?php _e('Allow my blog to appear in search engines like Google and Technorati.'); ?></label></td>
         </tr>
     </table>
-    <p><em><?php _e('Double-check that email address before continuing.'); ?></em></p>
-    <h2 class="step"><input type="submit" name="Submit" value="<?php _e('Continue to Second Step &raquo;'); ?>" /></h2>
+    <p><em><?php _e('Double-check your email address before continuing.'); ?></em></p>
+    <h2 class="step"><input type="submit" name="Submit" value="<?php _e('Install WordPress &raquo;'); ?>" /></h2>
 </form>
 
@@ -71 +70 @@
         // check e-mail address
         if (empty($admin_email)) {
-            die(__("<strong>ERROR</strong>: please type your e-mail address"));
+            // TODO: poka-yoke
+            die(__("<strong>ERROR</strong>: you must provide an e-mail address"));
         } else if (!is_email($admin_email)) {
-            die(__("<strong>ERROR</strong>: the e-mail address isn't correct"));
+            // TODO: poka-yoke
+            die(__('<strong>ERROR</strong>: that isn\'t a valid e-mail address.  E-mail addresses look like: <code>username@example.com</code>'));
         }
 
-?>
-<h1><?php _e('Second Step'); ?></h1>
-<p><?php _e('Now we&#8217;re going to create the database tables and fill them with some default data.'); ?></p>
-
-
-<?php
     $result = wp_install($weblog_title, 'admin', $admin_email, $public);
     extract($result, EXTR_SKIP);
 ?>
 
-<p><em><?php _e('Finished!'); ?></em></p>
+<h1><?php _e('Success!'); ?></h1>
 
-<p><?php printf(__('Now you can <a href="%1$s">log in</a> with the <strong>username</strong> "<code>admin</code>" and <strong>password</strong> "<code>%2$s</code>".'), '../wp-login.php', $password); ?></p>
-<p><?php _e('<strong><em>Note that password</em></strong> carefully! It is a <em>random</em> password that was generated just for you. If you lose it, you will have to delete the tables from the database yourself, and re-install WordPress. So to review:'); ?></p>
+<p><?php printf(__('WordPress has been installed.  Now you can <a href="%1$s">log in</a> with the <strong>username</strong> "<code>admin</code>" and <strong>password</strong> "<code>%2$s</code>".'), '../wp-login.php', $password); ?></p>
+<p><?php _e('<strong><em>Note that password</em></strong> carefully! It is a <em>random</em> password that was generated just for you.'); ?></p>
 
 <dl>
@@ -99 +94 @@
         <dd><a href="../wp-login.php">wp-login.php</a></dd>
 </dl>
-<p><?php _e('Were you expecting more steps? Sorry to disappoint. All done! :)'); ?></p>
+<p><?php _e('Were you expecting more steps? Sorry to disappoint. :)'); ?></p>
 
 <?php

trunk/wp-settings.php

@@ -143 +143 @@
 
 if ( !is_blog_installed() && (strpos($_SERVER['PHP_SELF'], 'install.php') === false && !defined('WP_INSTALLING')) ) {
-    if (strpos($_SERVER['PHP_SELF'], 'wp-admin') !== false)
-        $link = 'install.php';
+    if ( defined('WP_SITEURL') )
+        $link = WP_SITEURL . '/wp-admin/install.php'; 
+    elseif (strpos($_SERVER['PHP_SELF'], 'wp-admin') !== false)
+        $link = preg_replace('|/wp-admin/?.*?$|', '/', $_SERVER['PHP_SELF']) . 'wp-admin/install.php';
     else
-        $link = 'wp-admin/install.php';
-
-    wp_die( sprintf( 'It doesn&#8217;t look like you&#8217;ve installed WP yet. Try running <a href="%s">install.php</a>.', $link ) );
+        $link = preg_replace('|/[^/]+?$|', '/', $_SERVER['PHP_SELF']) . 'wp-admin/install.php';
+    require_once(ABSPATH . WPINC . '/kses.php');
+    require_once(ABSPATH . WPINC . '/pluggable.php');
+    wp_redirect($link);
+    die(); // have to die here ~ Mark
 }