Changeset 58462

Timestamp:

06/23/2024 11:38:49 AM (2 years ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in wp_get_block_css_selector() tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [56058].

See #60705.

File:

• trunk/tests/phpunit/tests/theme/wpGetBlockCssSelector.php (modified) (20 diffs)

trunk/tests/phpunit/tests/theme/wpGetBlockCssSelector.php

@@ -48 +48 @@
 
                 $selector = wp_get_block_css_selector( $block_type );
-                $this->assertEquals( '.wp-custom-block-class', $selector );
+                $this->assertSame( '.wp-custom-block-class', $selector );
         }
 
@@ -62 +62 @@
 
                 $selector = wp_get_block_css_selector( $block_type );
-                $this->assertEquals( '.experimental-selector', $selector );
+                $this->assertSame( '.experimental-selector', $selector );
         }
 
@@ -76 +76 @@
 
                 $selector = wp_get_block_css_selector( $block_type );
-                $this->assertEquals( '.wp-block-without-selectors-or-supports', $selector );
+                $this->assertSame( '.wp-block-without-selectors-or-supports', $selector );
         }
 
@@ -90 +90 @@
 
                 $selector = wp_get_block_css_selector( $block_type );
-                $this->assertEquals( '.wp-block-test-without-selectors-or-supports', $selector );
+                $this->assertSame( '.wp-block-test-without-selectors-or-supports', $selector );
         }
 
@@ -104 +104 @@
 
                 $selector = wp_get_block_css_selector( $block_type, 'typography' );
-                $this->assertEquals( '.typography', $selector );
+                $this->assertSame( '.typography', $selector );
         }
 
@@ -118 +118 @@
 
                 $selector = wp_get_block_css_selector( $block_type, 'typography' );
-                $this->assertEquals( '.typography', $selector );
+                $this->assertSame( '.typography', $selector );
         }
 
@@ -132 +132 @@
 
                 $selector = wp_get_block_css_selector( $block_type, 'typography' );
-                $this->assertEquals( null, $selector );
+                $this->assertSame( null, $selector );
         }
 
@@ -146 +146 @@
 
                 $selector = wp_get_block_css_selector( $block_type, 'typography', true );
-                $this->assertEquals( '.wp-block-test-fallback-feature-selector', $selector );
+                $this->assertSame( '.wp-block-test-fallback-feature-selector', $selector );
         }
 
@@ -160 +160 @@
 
                 $selector = wp_get_block_css_selector( $block_type, 'typography', true );
-                $this->assertEquals( '.fallback-root-selector', $selector );
+                $this->assertSame( '.fallback-root-selector', $selector );
         }
 
@@ -178 +178 @@
 
                 $selector = wp_get_block_css_selector( $block_type, 'typography' );
-                $this->assertEquals( '.wp-block-test-experimental-feature-selector .experimental-typography', $selector );
+                $this->assertSame( '.wp-block-test-experimental-feature-selector .experimental-typography', $selector );
         }
 
@@ -192 +192 @@
 
                 $selector = wp_get_block_css_selector( $block_type, 'typography', true );
-                $this->assertEquals( '.wp-block-test-fallback-feature-selector', $selector );
+                $this->assertSame( '.wp-block-test-fallback-feature-selector', $selector );
         }
 
@@ -206 +206 @@
 
                 $selector = wp_get_block_css_selector( $block_type, 'typography' );
-                $this->assertEquals( null, $selector );
+                $this->assertSame( null, $selector );
         }
 
@@ -228 +228 @@
                 );
 
-                $this->assertEquals( '.root .typography .text-decoration', $selector );
+                $this->assertSame( '.root .typography .text-decoration', $selector );
         }
 
@@ -249 +249 @@
                 );
 
-                $this->assertEquals( '.root .typography', $selector );
+                $this->assertSame( '.root .typography', $selector );
         }
 
@@ -263 +263 @@
 
                 $selector = wp_get_block_css_selector( $block_type, array( 'typography', 'fontSize' ) );
-                $this->assertEquals( null, $selector );
+                $this->assertSame( null, $selector );
         }
 
@@ -281 +281 @@
                         true
                 );
-                $this->assertEquals( '.wp-block-test-fallback-subfeature-selector', $selector );
+                $this->assertSame( '.wp-block-test-fallback-subfeature-selector', $selector );
         }
 
@@ -298 +298 @@
                         array( 'typography', 'fontSize' )
                 );
-                $this->assertEquals( null, $selector );
+                $this->assertSame( null, $selector );
         }
 
@@ -312 +312 @@
 
                 $selector = wp_get_block_css_selector( $block_type, array() );
-                $this->assertEquals( null, $selector );
+                $this->assertSame( null, $selector );
 
                 $selector = wp_get_block_css_selector( $block_type, '' );
-                $this->assertEquals( null, $selector );
+                $this->assertSame( null, $selector );
         }
 
@@ -329 +329 @@
 
                 $selector = wp_get_block_css_selector( $block_type, 'typography' );
-                $this->assertEquals( '.found', $selector );
+                $this->assertSame( '.found', $selector );
 
                 $selector = wp_get_block_css_selector( $block_type, array( 'typography' ) );
-                $this->assertEquals( '.found', $selector );
+                $this->assertSame( '.found', $selector );
         }
 
@@ -348 +348 @@
 
                 $selector = wp_get_block_css_selector( $block_type, 'typography.fontSize' );
-                $this->assertEquals( '.found', $selector );
+                $this->assertSame( '.found', $selector );
 
                 $selector = wp_get_block_css_selector( $block_type, array( 'typography', 'fontSize' ) );
-                $this->assertEquals( '.found', $selector );
+                $this->assertSame( '.found', $selector );
         }
 }