Changeset 58578

Timestamp:

06/26/2024 08:52:12 AM (3 months ago)

Author:

Bernhard Reiter

Message:

Block Hooks: Refactor controller filter to use meta_input.

Prior to this changeset, the function update_ignored_hooked_blocks_postmeta() used the core function update_post_meta() to write _wp_ignored_hooked_blocks data to the database during an operation that is preparing a post to be inserted.

Since we have access to the incoming changes that are being prepared we can remove this database operation in favour of writing the data to the post object provided under meta_input.

Doing this means two things:

1. It allows us to store postmeta for new posts that are about to be created since they don't have an ID yet (which is information update_post_meta() needs).
2. The core controller will take care of updating postmeta in a more predictable pattern.

Props tomjcafferkey, bernhard-reiter.
Fixes #61495.

Location:

trunk

Files:

• src/wp-includes/blocks.php (modified) (2 diffs)
• tests/phpunit/tests/blocks/updateIgnoredHookedBlocksPostMeta.php (modified) (1 diff)

trunk/src/wp-includes/blocks.php

@@ -1096 +1096 @@
     );
 
-    $serialized_block = apply_block_hooks_to_content( $markup, get_post( $post->ID ), 'set_ignored_hooked_blocks_metadata' );
+    $existing_post = get_post( $post->ID );
+    // Merge the existing post object with the updated post object to pass to the block hooks algorithm for context.
+    $context          = (object) array_merge( (array) $existing_post, (array) $post );
+    $serialized_block = apply_block_hooks_to_content( $markup, $context, 'set_ignored_hooked_blocks_metadata' );
     $root_block       = parse_blocks( $serialized_block )[0];
 
@@ -1109 +1112 @@
             $ignored_hooked_blocks          = array_unique( array_merge( $ignored_hooked_blocks, $existing_ignored_hooked_blocks ) );
         }
-        update_post_meta( $post->ID, '_wp_ignored_hooked_blocks', json_encode( $ignored_hooked_blocks ) );
+
+        if ( ! isset( $post->meta_input ) ) {
+            $post->meta_input = array();
+        }
+        $post->meta_input['_wp_ignored_hooked_blocks'] = json_encode( $ignored_hooked_blocks );
     }
 

trunk/tests/phpunit/tests/blocks/updateIgnoredHookedBlocksPostMeta.php

@@ -76 +76 @@
         $this->assertSame(
             array( 'tests/my-block' ),
-            json_decode( get_post_meta( self::$navigation_post->ID, '_wp_ignored_hooked_blocks', true ), true ),
+            json_decode( $post->meta_input['_wp_ignored_hooked_blocks'], true ),
             'Block was not added to ignored hooked blocks metadata.'
         );