WordPress.org
Get WordPress

Make WordPress Core


Ignore:
Timestamp:
06/28/2024 03:45:08 PM (20 months ago)
Author:
SergeyBiryukov
Message:

Tests: Use assertSame() in WP_Interactivity_API tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [57563], [57649], [57822], [57826], [57835], [58159], [58327].

See #61530.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/tests/phpunit/tests/interactivity-api/wpInteractivityAPI-wp-context.php

    r58321 r58594  
    5757        ';
    5858        list($p) = $this->process_directives( $html );
    59         $this->assertEquals( 'some-id', $p->get_attribute( 'id' ) );
     59        $this->assertSame( 'some-id', $p->get_attribute( 'id' ) );
    6060    }
    6161
    … …  
    7979        ';
    8080        list($p) = $this->process_directives( $html );
    81         $this->assertEquals( 'some-id', $p->get_attribute( 'id' ) );
     81        $this->assertSame( 'some-id', $p->get_attribute( 'id' ) );
    8282    }
    8383
    … …  
    100100        ';
    101101        list($p) = $this->process_directives( $html );
    102         $this->assertEquals( 'some-id-1', $p->get_attribute( 'id' ) );
    103         $p->next_tag( array( 'class_name' => 'test' ) );
    104         $this->assertEquals( 'some-id-2', $p->get_attribute( 'id' ) );
     102        $this->assertSame( 'some-id-1', $p->get_attribute( 'id' ) );
     103        $p->next_tag( array( 'class_name' => 'test' ) );
     104        $this->assertSame( 'some-id-2', $p->get_attribute( 'id' ) );
    105105    }
    106106
    … …  
    122122        ';
    123123        list($p) = $this->process_directives( $html );
    124         $this->assertEquals( 'some-id-2', $p->get_attribute( 'id' ) );
     124        $this->assertSame( 'some-id-2', $p->get_attribute( 'id' ) );
    125125    }
    126126
    … …  
    143143        ';
    144144        list($p) = $this->process_directives( $html );
    145         $this->assertEquals( 'some-id-2', $p->get_attribute( 'id' ) );
    146         $p->next_tag( array( 'class_name' => 'test' ) );
    147         $this->assertEquals( 'some-id-1', $p->get_attribute( 'id' ) );
     145        $this->assertSame( 'some-id-2', $p->get_attribute( 'id' ) );
     146        $p->next_tag( array( 'class_name' => 'test' ) );
     147        $this->assertSame( 'some-id-1', $p->get_attribute( 'id' ) );
    148148    }
    149149
    … …  
    166166        ';
    167167        list($p) = $this->process_directives( $html );
    168         $this->assertEquals( 'some-id-1', $p->get_attribute( 'id' ) );
    169         $p->next_tag( array( 'class_name' => 'test' ) );
    170         $this->assertEquals( 'some-id-2', $p->get_attribute( 'id' ) );
     168        $this->assertSame( 'some-id-1', $p->get_attribute( 'id' ) );
     169        $p->next_tag( array( 'class_name' => 'test' ) );
     170        $this->assertSame( 'some-id-2', $p->get_attribute( 'id' ) );
    171171    }
    172172
    … …  
    207207        ';
    208208        list($p) = $this->process_directives( $html );
    209         $this->assertEquals( 'some-id-1', $p->get_attribute( 'id' ) );
    210         $p->next_tag( array( 'class_name' => 'test' ) );
    211         $this->assertEquals( 'some-id-1', $p->get_attribute( 'id' ) );
     209        $this->assertSame( 'some-id-1', $p->get_attribute( 'id' ) );
     210        $p->next_tag( array( 'class_name' => 'test' ) );
     211        $this->assertSame( 'some-id-1', $p->get_attribute( 'id' ) );
    212212    }
    213213
    … …  
    248248        ';
    249249        list($p) = $this->process_directives( $html );
    250         $this->assertEquals( 'some-id-1', $p->get_attribute( 'id' ) );
    251         $p->next_tag( array( 'class_name' => 'test' ) );
    252         $this->assertEquals( 'some-id-1', $p->get_attribute( 'id' ) );
     250        $this->assertSame( 'some-id-1', $p->get_attribute( 'id' ) );
     251        $p->next_tag( array( 'class_name' => 'test' ) );
     252        $this->assertSame( 'some-id-1', $p->get_attribute( 'id' ) );
    253253    }
    254254
    … …  
    289289        ';
    290290        list($p) = $this->process_directives( $html );
    291         $this->assertEquals( 'some-id-1', $p->get_attribute( 'id' ) );
    292         $p->next_tag( array( 'class_name' => 'test' ) );
    293         $this->assertEquals( 'some-id-1', $p->get_attribute( 'id' ) );
     291        $this->assertSame( 'some-id-1', $p->get_attribute( 'id' ) );
     292        $p->next_tag( array( 'class_name' => 'test' ) );
     293        $this->assertSame( 'some-id-1', $p->get_attribute( 'id' ) );
    294294    }
    295295
    … …  
    308308        ';
    309309        list($p) = $this->process_directives( $html );
    310         $this->assertEquals( 'some-id', $p->get_attribute( 'id' ) );
     310        $this->assertSame( 'some-id', $p->get_attribute( 'id' ) );
    311311    }
    312312
    … …  
    347347        ';
    348348        list($p) = $this->process_directives( $html );
    349         $this->assertEquals( 'some-id', $p->get_attribute( 'id' ) );
     349        $this->assertSame( 'some-id', $p->get_attribute( 'id' ) );
    350350    }
    351351
    … …  
    369369        ';
    370370        list($p) = $this->process_directives( $html );
    371         $this->assertEquals( 'some-id', $p->get_attribute( 'id' ) );
     371        $this->assertSame( 'some-id', $p->get_attribute( 'id' ) );
    372372    }
    373373
    … …  
    390390        ';
    391391        list($p) = $this->process_directives( $html );
    392         $this->assertEquals( 'some-id', $p->get_attribute( 'id' ) );
     392        $this->assertSame( 'some-id', $p->get_attribute( 'id' ) );
    393393    }
    394394
    … …  
    417417        ';
    418418        list($p) = $this->process_directives( $html );
    419         $this->assertEquals( 'other-id', $p->get_attribute( 'id' ) );
    420         $p->next_tag( array( 'class_name' => 'test' ) );
    421         $this->assertEquals( 'some-id', $p->get_attribute( 'id' ) );
    422         $p->next_tag( array( 'class_name' => 'test' ) );
    423         $this->assertEquals( 'some-id', $p->get_attribute( 'id' ) );
     419        $this->assertSame( 'other-id', $p->get_attribute( 'id' ) );
     420        $p->next_tag( array( 'class_name' => 'test' ) );
     421        $this->assertSame( 'some-id', $p->get_attribute( 'id' ) );
     422        $p->next_tag( array( 'class_name' => 'test' ) );
     423        $this->assertSame( 'some-id', $p->get_attribute( 'id' ) );
    424424        $p->next_tag( array( 'class_name' => 'test' ) );
    425425        $this->assertNull( $p->get_attribute( 'id' ) );
    … …  
    446446        ';
    447447        list($p) = $this->process_directives( $html );
    448         $this->assertEquals( 'some-id', $p->get_attribute( 'id' ) );
     448        $this->assertSame( 'some-id', $p->get_attribute( 'id' ) );
    449449    }
    450450
    … …  
    470470        ';
    471471        list($p) = $this->process_directives( $html );
    472         $this->assertEquals( 'some-id-1', $p->get_attribute( 'id' ) );
    473         $p->next_tag( array( 'class_name' => 'test' ) );
    474         $this->assertEquals( 'some-id-2', $p->get_attribute( 'id' ) );
     472        $this->assertSame( 'some-id-1', $p->get_attribute( 'id' ) );
     473        $p->next_tag( array( 'class_name' => 'test' ) );
     474        $this->assertSame( 'some-id-2', $p->get_attribute( 'id' ) );
    475475    }
    476476
    … …  
    495495        ';
    496496        list($p) = $this->process_directives( $html );
    497         $this->assertEquals( 'some-id-2', $p->get_attribute( 'id' ) );
     497        $this->assertSame( 'some-id-2', $p->get_attribute( 'id' ) );
    498498    }
    499499
    … …  
    519519        ';
    520520        list($p) = $this->process_directives( $html );
    521         $this->assertEquals( 'some-id-2', $p->get_attribute( 'id' ) );
    522         $p->next_tag( array( 'class_name' => 'test' ) );
    523         $this->assertEquals( 'some-id-1', $p->get_attribute( 'id' ) );
     521        $this->assertSame( 'some-id-2', $p->get_attribute( 'id' ) );
     522        $p->next_tag( array( 'class_name' => 'test' ) );
     523        $this->assertSame( 'some-id-1', $p->get_attribute( 'id' ) );
    524524    }
    525525}
Note: See TracChangeset for help on using the changeset viewer.