WordPress.org
Get WordPress

Make WordPress Core


Ignore:
Timestamp:
06/28/2024 03:45:08 PM (22 months ago)
Author:
SergeyBiryukov
Message:

Tests: Use assertSame() in WP_Interactivity_API tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [57563], [57649], [57822], [57826], [57835], [58159], [58327].

See #61530.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/tests/phpunit/tests/interactivity-api/wpInteractivityAPI-wp-each.php

    r58327 r58594  
    4343            </div>';
    4444        $new      = $this->interactivity->process_directives( $original );
    45         $this->assertEquals( $original, $new );
     45        $this->assertSame( $original, $new );
    4646    }
    4747
    … …  
    6969            </template>';
    7070        $new      = $this->interactivity->process_directives( $original );
    71         $this->assertEquals( $original, $new );
     71        $this->assertSame( $original, $new );
    7272    }
    7373
    … …  
    9393            '<div id="after-wp-each" data-wp-bind--id="myPlugin::state.after">Text</div>';
    9494        $new      = $this->interactivity->process_directives( $original );
    95         $this->assertEquals( $expected, $new );
     95        $this->assertSame( $expected, $new );
    9696    }
    9797
    … …  
    117117            '<div id="after-wp-each" data-wp-bind--id="myPlugin::state.after">Text</div>';
    118118        $new      = $this->interactivity->process_directives( $original );
    119         $this->assertEquals( $expected, $new );
     119        $this->assertSame( $expected, $new );
    120120    }
    121121
    … …  
    146146            '</div>';
    147147        $new      = $this->interactivity->process_directives( $original );
    148         $this->assertEquals( $expected, $new );
     148        $this->assertSame( $expected, $new );
    149149    }
    150150
    … …  
    174174            '</div>';
    175175        $new      = $this->interactivity->process_directives( $original );
    176         $this->assertEquals( $expected, $new );
     176        $this->assertSame( $expected, $new );
    177177    }
    178178
    … …  
    202202            '</div>';
    203203        $new      = $this->interactivity->process_directives( $original );
    204         $this->assertEquals( $expected, $new );
     204        $this->assertSame( $expected, $new );
    205205    }
    206206
    … …  
    230230            '<div id="after-wp-each" data-wp-bind--id="myPlugin::state.after">Text</div>';
    231231        $new      = $this->interactivity->process_directives( $original );
    232         $this->assertEquals( $expected, $new );
     232        $this->assertSame( $expected, $new );
    233233    }
    234234
    … …  
    258258            '<div id="after-wp-each" data-wp-bind--id="myPlugin::state.after">Text</div>';
    259259        $new      = $this->interactivity->process_directives( $original );
    260         $this->assertEquals( $expected, $new );
     260        $this->assertSame( $expected, $new );
    261261    }
    262262
    … …  
    287287            '<div id="after-wp-each" data-wp-bind--id="myPlugin::state.after">Text</div>';
    288288        $new      = $this->interactivity->process_directives( $original );
    289         $this->assertEquals( $expected, $new );
     289        $this->assertSame( $expected, $new );
    290290    }
    291291
    … …  
    319319            '<div id="after-wp-each" data-wp-bind--id="myPlugin::state.after">Text</div>';
    320320        $new      = $this->interactivity->process_directives( $original );
    321         $this->assertEquals( $expected, $new );
     321        $this->assertSame( $expected, $new );
    322322    }
    323323
    … …  
    362362            '<div id="after-wp-each" data-wp-bind--id="myPlugin::state.after">Text</div>';
    363363        $new      = $this->interactivity->process_directives( $original );
    364         $this->assertEquals( $expected, $new );
     364        $this->assertSame( $expected, $new );
    365365    }
    366366
    … …  
    386386            '<div id="after-wp-each" data-wp-bind--id="myPlugin::state.after">Text</div>';
    387387        $new      = $this->interactivity->process_directives( $original );
    388         $this->assertEquals( $expected, $new );
     388        $this->assertSame( $expected, $new );
    389389    }
    390390
    … …  
    411411            '<div id="after-wp-each" data-wp-bind--id="myPlugin::state.after">Text</div>';
    412412        $new      = $this->interactivity->process_directives( $original );
    413         $this->assertEquals( $expected, $new );
     413        $this->assertSame( $expected, $new );
    414414    }
    415415
    … …  
    427427            '</template>';
    428428        $new      = $this->interactivity->process_directives( $original );
    429         $this->assertEquals( $original, $new );
     429        $this->assertSame( $original, $new );
    430430
    431431        $original = '' .
    … …  
    434434            '</template>';
    435435        $new      = $this->interactivity->process_directives( $original );
    436         $this->assertEquals( $original, $new );
     436        $this->assertSame( $original, $new );
    437437
    438438        // But it should work fine with spaces and linebreaks.
    … …  
    445445        $p->next_tag( array( 'class_name' => 'test' ) );
    446446        $p->next_tag( array( 'class_name' => 'test' ) );
    447         $this->assertEquals( '1', $p->get_attribute( 'id' ) );
     447        $this->assertSame( '1', $p->get_attribute( 'id' ) );
    448448        $p->next_tag( array( 'class_name' => 'test' ) );
    449         $this->assertEquals( '2', $p->get_attribute( 'id' ) );
     449        $this->assertSame( '2', $p->get_attribute( 'id' ) );
    450450    }
    451451
    … …  
    488488            '<div id="after-wp-each" data-wp-bind--id="myPlugin::state.after">Text</div>';
    489489        $new      = $this->interactivity->process_directives( $original );
    490         $this->assertEquals( $expected, $new );
     490        $this->assertSame( $expected, $new );
    491491    }
    492492
    … …  
    534534            '<div id="after-wp-each" data-wp-bind--id="myPlugin::state.after">Text</div>';
    535535        $new      = $this->interactivity->process_directives( $original );
    536         $this->assertEquals( $expected, $new );
     536        $this->assertSame( $expected, $new );
    537537    }
    538538
    … …  
    572572            '<div id="after-wp-each" data-wp-bind--id="myPlugin::state.after">Text</div>';
    573573        $new      = $this->interactivity->process_directives( $original );
    574         $this->assertEquals( $expected, $new );
     574        $this->assertSame( $expected, $new );
    575575    }
    576576
    … …  
    591591            '<div data-wp-bind--id="myPlugin::state.after">Text</div>';
    592592        $new      = $this->interactivity->process_directives( $original );
    593         $this->assertEquals( $original, $new );
     593        $this->assertSame( $original, $new );
    594594    }
    595595
    … …  
    615615            '<div data-wp-bind--id="myPlugin::state.after">Text</div>';
    616616        $new      = $this->interactivity->process_directives( $original );
    617         $this->assertEquals( $original, $new );
     617        $this->assertSame( $original, $new );
    618618    }
    619619
    … …  
    640640        $this->interactivity->state( 'myPlugin', array( 'list' => null ) );
    641641        $new = $this->interactivity->process_directives( $original );
    642         $this->assertEquals( $expected, $new );
     642        $this->assertSame( $expected, $new );
    643643
    644644        $this->interactivity->state( 'myPlugin', array( 'list' => 'Text' ) );
    645645        $new = $this->interactivity->process_directives( $original );
    646         $this->assertEquals( $expected, $new );
     646        $this->assertSame( $expected, $new );
    647647
    648648        $this->interactivity->state( 'myPlugin', array( 'list' => 100 ) );
    649649        $new = $this->interactivity->process_directives( $original );
    650         $this->assertEquals( $expected, $new );
     650        $this->assertSame( $expected, $new );
    651651
    652652        $this->interactivity->state( 'myPlugin', array( 'list' => false ) );
    653653        $new = $this->interactivity->process_directives( $original );
    654         $this->assertEquals( $expected, $new );
     654        $this->assertSame( $expected, $new );
    655655
    656656        $this->interactivity->state( 'myPlugin', array( 'list' => true ) );
    657657        $new = $this->interactivity->process_directives( $original );
    658         $this->assertEquals( $expected, $new );
     658        $this->assertSame( $expected, $new );
    659659    }
    660660
    … …  
    683683            '<div id="after-wp-each" data-wp-bind--id="myPlugin::state.after">Text</div>';
    684684        $new      = $this->interactivity->process_directives( $original );
    685         $this->assertEquals( $expected, $new );
     685        $this->assertSame( $expected, $new );
    686686    }
    687687}
Note: See TracChangeset for help on using the changeset viewer.