Changeset 58594 for trunk/tests/phpunit/tests/interactivity-api/wpInteractivityAPI-wp-router-region.php

Timestamp:

06/28/2024 03:45:08 PM (23 months ago)

Author:

SergeyBiryukov

Message:

Tests: Use assertSame() in WP_Interactivity_API tests.

This ensures that not only the return values match the expected results, but also that their type is the same.

Going forward, stricter type checking by using assertSame() should generally be preferred to assertEquals() where appropriate, to make the tests more reliable.

Follow-up to [57563], [57649], [57822], [57826], [57835], [58159], [58327].

See #61530.

File:

• trunk/tests/phpunit/tests/interactivity-api/wpInteractivityAPI-wp-router-region.php (modified) (3 diffs)

trunk/tests/phpunit/tests/interactivity-api/wpInteractivityAPI-wp-router-region.php

@@ -89 +89 @@
         $new_html = $this->interactivity->process_directives( $html );
         $footer   = $this->render_wp_footer();
-        $this->assertEquals( $html, $new_html );
-        $this->assertEquals( '', $footer );
-        $this->assertEquals( '', get_echo( 'wp_print_styles' ) );
+        $this->assertSame( $html, $new_html );
+        $this->assertSame( '', $footer );
+        $this->assertSame( '', get_echo( 'wp_print_styles' ) );
     }
 
@@ -109 +109 @@
         ';
         $new_html = $this->interactivity->process_directives( $html );
-        $this->assertEquals( $html, $new_html );
+        $this->assertSame( $html, $new_html );
 
         // Check that the style is loaded, but only once.
@@ -116 +116 @@
         $p      = new WP_HTML_Tag_Processor( $styles );
         $this->assertTrue( $p->next_tag( $query ) );
-        $this->assertEquals( 'wp-interactivity-router-animations-inline-css', $p->get_attribute( 'id' ) );
+        $this->assertSame( 'wp-interactivity-router-animations-inline-css', $p->get_attribute( 'id' ) );
         $this->assertStringContainsString( '.wp-interactivity-router-loading-bar', $styles );
         $this->assertFalse( $p->next_tag( $query ) );