Changeset 58596

Timestamp:

06/28/2024 06:19:51 PM (11 months ago)

Author:

desrosj

Message:

Build/Test Tools: Allow older branches to use Coding Standards workflow.

This updates the reusable coding standards GitHub Actions workflow to support the old way of running PHPCS commands when the old-branches input flag is set to true. This allows the 5.1-5.4 branches to use the same workflow as all other 5.5+ branches.

See #61213.

File:

• trunk/.github/workflows/reusable-coding-standards-php.yml (modified) (4 diffs)

trunk/.github/workflows/reusable-coding-standards-php.yml

@@ -12 +12 @@
         type: 'string'
         default: 'latest'
+      old-branch:
+        description: 'Whether this is an old branch that runs phpcbf instead of phpcs'
+        required: false
+        type: 'boolean'
+        default: false
 
 jobs:
@@ -75 +80 @@
       - name: Run PHPCS on all Core files
         id: phpcs-core
+        if: ${{ ! inputs.old-branch }}
         run: phpcs -n --report-full --cache=./.cache/phpcs-src.json --report-checkstyle=./.cache/phpcs-report.xml
 
@@ -83 +89 @@
       - name: Check test suite files for warnings
         id: phpcs-tests
+        if: ${{ ! inputs.old-branch }}
         run: phpcs tests --report-full --cache=./.cache/phpcs-tests.json --report-checkstyle=./.cache/phpcs-tests-report.xml
 
@@ -89 +96 @@
         run: cs2pr ./.cache/phpcs-tests-report.xml
 
+      - name: Run PHPCBF on all Core files (old branches)
+        if: ${{ inputs.old-branch }}
+        run: phpcbf
+
       - name: Ensure version-controlled files are not modified during the tests
         run: git diff --exit-code