Changeset 58682 for trunk/tests/phpunit/tests/http/http.php

Timestamp:

07/06/2024 02:52:05 PM (2 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Remove obsolete comments about older PHP versions.

This commit:

• Removes various comments referencing PHP versions which are no longer supported.
• Removes various comments containing “hints” of things to do after a particular PHP version drop. These hints are incorrect/not actionable for various reasons, so have no value:
  • Even though a function could be turned into a closure, removing the function would be a backward compatibility break which is not acceptable, so this suggestion is not actionable.
  • Short ternaries are forbidden by the coding standard exactly to prevent the faulty code suggested in the comment from getting into the codebase.

Follow-up to [1243/tests], [6543], [11816], [29861], [29864], [34928], [35369], [36698], [38694], [50786], [58678].

Props jrf, ayeshrajans.
See #61574.

File:

• trunk/tests/phpunit/tests/http/http.php (modified) (6 diffs)

trunk/tests/phpunit/tests/http/http.php

@@ -115 +115 @@
             ),
 
-            // < PHP 5.4.7: Schemeless URL.
+            // Schemeless URL.
             array(
                 '//example.com/path/',
@@ -139 +139 @@
             ),
 
-            // < PHP 5.4.7: Scheme separator in the URL.
+            // Scheme separator in the URL.
             array(
                 'http://example.com/http://example.net/',
@@ -150 +150 @@
             array( '/path/http://example.net/', array( 'path' => '/path/http://example.net/' ) ),
 
-            // < PHP 5.4.7: IPv6 literals in schemeless URLs are handled incorrectly.
+            // IPv6 literals in schemeless URLs.
             array(
                 '//[::FFFF::127.0.0.1]/',
@@ -239 +239 @@
             array( self::FULL_TEST_URL, PHP_URL_FRAGMENT, 'anchor' ),
 
-            // < PHP 5.4.7: Schemeless URL.
+            // Schemeless URL.
             array( '//example.com/path/', PHP_URL_HOST, 'example.com' ),
             array( '//example.com/path/', PHP_URL_PATH, '/path/' ),
@@ -247 +247 @@
             array( 'http://example.com//path/', PHP_URL_PATH, '//path/' ),
 
-            // < PHP 5.4.7: Scheme separator in the URL.
+            // Scheme separator in the URL.
             array( 'http://example.com/http://example.net/', PHP_URL_HOST, 'example.com' ),
             array( 'http://example.com/http://example.net/', PHP_URL_PATH, '/http://example.net/' ),
@@ -253 +253 @@
             array( '/path/http://example.net/', PHP_URL_PATH, '/path/http://example.net/' ),
 
-            // < PHP 5.4.7: IPv6 literals in schemeless URLs are handled incorrectly.
+            // IPv6 literals in schemeless URLs.
             array( '//[::FFFF::127.0.0.1]/', PHP_URL_HOST, '[::FFFF::127.0.0.1]' ),
             array( '//[::FFFF::127.0.0.1]/', PHP_URL_PATH, '/' ),