Changeset 58684

Timestamp:

07/07/2024 12:42:44 PM (9 months ago)

Author:

SergeyBiryukov

Message:

Code Modernization: Replace substr( PHP_OS, 0, 3 ) calls with PHP_OS_FAMILY.

The PHP_OS_FAMILY constant indicates the operating system family PHP was built for, and is available as of PHP 7.2.0.

Reference: ​PHP Manual: Predefined Constants: PHP_OS_FAMILY.

Follow-up to [23255], [57753], [57985], [58678].

Props ayeshrajans, jrf.
See #61574.

Location:

trunk

Files:

• src/wp-includes/functions.php (modified) (1 diff)
• tests/phpunit/tests/filesystem/wpFilesystemDirect/base.php (modified) (1 diff)

trunk/src/wp-includes/functions.php

@@ -2258 +2258 @@
  */
 function wp_is_writable( $path ) {
-    if ( 'WIN' === strtoupper( substr( PHP_OS, 0, 3 ) ) ) {
+    if ( 'Windows' === PHP_OS_FAMILY ) {
         return win_is_writable( $path );
-    } else {
-        return @is_writable( $path );
-    }
+    }
+
+    return @is_writable( $path );
 }
 

trunk/tests/phpunit/tests/filesystem/wpFilesystemDirect/base.php

@@ -161 +161 @@
      */
     public static function is_windows() {
-        return 'WIN' === substr( PHP_OS, 0, 3 );
+        return 'Windows' === PHP_OS_FAMILY;
     }