Changeset 58687

Timestamp:

07/08/2024 10:43:22 AM (2 years ago)

Author:

karmatosed

Message:

Twenty Seventeen: Fixes front page panels allow pages of any status to be shown.

If you have a published page set to a section but also private, draft, pending or trash at some point in the future it was still showing on the homepage. There was no clarity to the user what was happening. This adds in a check to the post_status variable before displaying panel content and adjusts the customizer to show a placeholder if the page is draft,trashed,deleted.

Props brettshumaker, sabernhardt.
Fixes #46604.

File:

• trunk/src/wp-content/themes/twentyseventeen/inc/template-tags.php (modified) (2 diffs)

trunk/src/wp-content/themes/twentyseventeen/inc/template-tags.php

@@ -150 +150 @@
         }
 
+        // Only when in Customizer, use a placeholder for an empty panel.
+        $show_panel_placeholder = false;
+
         global $post; // Modify the global post object before setting up post data.
         if ( get_theme_mod( 'panel_' . $id ) ) {
@@ -156 +159 @@
                 set_query_var( 'panel', $id );
 
-                get_template_part( 'template-parts/page/content', 'front-page-panels' );
+                if ( $post && in_array( $post->post_status, array( 'publish', 'private' ), true ) ) {
+                        get_template_part( 'template-parts/page/content', 'front-page-panels' );
+                } elseif ( is_customize_preview() ) {
+                        $show_panel_placeholder = true;
+                }
 
                 wp_reset_postdata();
         } elseif ( is_customize_preview() ) {
+                $show_panel_placeholder = true;
+        }
+
+        if ( $show_panel_placeholder ) {
                 // The output placeholder anchor.
                 printf(