Changeset 58713 for trunk/tests/phpunit/tests/html-api/wpHtmlProcessorSemanticRules.php

Timestamp:

07/12/2024 10:18:16 PM (22 months ago)

Author:

dmsnell

Message:

HTML API: Simplify breadcrumb accounting.

Since the HTML Processor started visiting all nodes in a document, both
real and virtual, the breadcrumb accounting became a bit complicated
and it's not entirely clear that it is fully reliable.

In this patch the breadcrumbs are rebuilt separately from the stack of
open elements in order to eliminate the problem of the stateful stack
interactions and the post-hoc event queue.

Breadcrumbs are greatly simplified as a result, and more verifiably
correct, in this construction.

Developed in ​https://github.com/WordPress/wordpress-develop/pull/6981
Discussed in https://core.trac.wordpress.org/ticket/61576

Follow-up to [58590].

Props bernhard-reiter, dmsnell.
See #61576.

File:

• trunk/tests/phpunit/tests/html-api/wpHtmlProcessorSemanticRules.php (modified) (1 diff)

trunk/tests/phpunit/tests/html-api/wpHtmlProcessorSemanticRules.php

@@ -388 +388 @@
         $this->assertSame( array( 'HTML', 'BODY', 'DIV', 'SPAN', 'CODE' ), $processor->get_breadcrumbs(), 'Failed to produce expected DOM nesting.' );
 
-        $this->assertTrue( $processor->next_token(), 'Failed to advance past CODE tag to expected SPAN closer.' );
+        $this->assertTrue(
+            $processor->next_tag(
+                array(
+                    'tag_name'    => 'SPAN',
+                    'tag_closers' => 'visit',
+                )
+            ),
+            'Failed to advance past CODE tag to expected SPAN closer.'
+        );
+        $this->assertSame( 'SPAN', $processor->get_tag() );
         $this->assertTrue( $processor->is_tag_closer(), 'Expected to find closing SPAN, but found opener instead.' );
         $this->assertSame( array( 'HTML', 'BODY', 'DIV' ), $processor->get_breadcrumbs(), 'Failed to advance past CODE tag to expected DIV opener.' );