Changeset 58749 for trunk/src/wp-includes/class-wp-theme-json.php

Timestamp:

07/18/2024 06:41:29 AM (6 months ago)

Author:

noisysocks

Message:

Block Themes: Avoid specificity bump for top-level element-only selectors

Prevent issues (e.g. links being underlined) caused by a bump in CSS
specificity for top-level element-only global element styles.

Backports the PHP changes from ​https://github.com/WordPress/gutenberg/pull/63403.

Fixes #61630.
Fixes #61660.
Props aaronrobertshaw, andrewserong, noisysocks.

File:

• trunk/src/wp-includes/class-wp-theme-json.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-theme-json.php

@@ -2889 +2889 @@
         }
 
+        /*
+         * Top-level element styles using element-only specificity selectors should
+         * not get wrapped in `:root :where()` to maintain backwards compatibility.
+         *
+         * Pseudo classes, e.g. :hover, :focus etc., are a class-level selector so
+         * still need to be wrapped in `:root :where` to cap specificity for nested
+         * variations etc. Pseudo selectors won't match the ELEMENTS selector exactly.
+         */
+        $element_only_selector = $current_element &&
+            isset( static::ELEMENTS[ $current_element ] ) &&
+            // buttons, captions etc. still need `:root :where()` as they are class based selectors.
+            ! isset( static::__EXPERIMENTAL_ELEMENT_CLASS_NAMES[ $current_element ] ) &&
+            static::ELEMENTS[ $current_element ] === $selector;
+
         // 2. Generate and append the rules that use the general selector.
-        $block_rules .= static::to_ruleset( ":root :where($selector)", $declarations );
+        $general_selector = $element_only_selector ? $selector : ":root :where($selector)";
+        $block_rules     .= static::to_ruleset( $general_selector, $declarations );
 
         // 3. Generate and append the rules that use the duotone selector.