Changeset 58750

Timestamp:

07/18/2024 06:48:08 AM (2 months ago)

Author:

noisysocks

Message:

Block Themes: Fix invalid css for nested fullwidth layouts with zero padding applied

In the Layout block support, handle 0 values for padding as 0px in calc()
rules. This resolves a bug for nested fullwidth layouts when zero padding is
applied. Due to how calc() works, without supplying the unit, the rule will not
work, resulting in a horizontal scrollbar.

Backports the PHP changes in ​https://github.com/WordPress/gutenberg/pull/63436.

Fixes #61656.
Props andrewserong, mukesh27, aaronrobertshaw.

File:

• trunk/src/wp-includes/block-supports/layout.php (modified) (2 diffs)

trunk/src/wp-includes/block-supports/layout.php

@@ -323 +323 @@
              */
             if ( isset( $block_spacing_values['declarations']['padding-right'] ) ) {
-                $padding_right   = $block_spacing_values['declarations']['padding-right'];
+                $padding_right = $block_spacing_values['declarations']['padding-right'];
+                // Add unit if 0.
+                if ( '0' === $padding_right ) {
+                    $padding_right = '0px';
+                }
                 $layout_styles[] = array(
                     'selector'     => "$selector > .alignfull",
@@ -330 +334 @@
             }
             if ( isset( $block_spacing_values['declarations']['padding-left'] ) ) {
-                $padding_left    = $block_spacing_values['declarations']['padding-left'];
+                $padding_left = $block_spacing_values['declarations']['padding-left'];
+                // Add unit if 0.
+                if ( '0' === $padding_left ) {
+                    $padding_left = '0px';
+                }
                 $layout_styles[] = array(
                     'selector'     => "$selector > .alignfull",